Re: [Qemu-devel] [PATCH 08/12] ahci: add ahci emulation

2010-11-25 Thread Paul Brook
> > less than half of the targets are big-endian. If it's broken on > > big-endian there should be a comment somewhere documenting this, so we > > know to fix it. > > Well, it's stated in the cover letter and the same is true for almost every > PCI device in qemu we have today. So what would you p

Re: [Qemu-devel] [PATCH 08/12] ahci: add ahci emulation

2010-11-25 Thread Alexander Graf
On 25.11.2010, at 13:45, Paul Brook wrote: >> On 25.11.2010, at 13:28, Paul Brook wrote: Makefile.objs |1 + default-configs/i386-softmmu.mak |1 + default-configs/x86_64-softmmu.mak |1 + >>> >>> Why are you only enabling this on x86? PCI devices,

Re: [Qemu-devel] [PATCH 08/12] ahci: add ahci emulation

2010-11-25 Thread Paul Brook
> On 25.11.2010, at 13:28, Paul Brook wrote: > >> Makefile.objs |1 + > >> default-configs/i386-softmmu.mak |1 + > >> default-configs/x86_64-softmmu.mak |1 + > > > > Why are you only enabling this on x86? PCI devices, especially things > > like SATA controllers,

Re: [Qemu-devel] [PATCH 08/12] ahci: add ahci emulation

2010-11-25 Thread Alexander Graf
On 25.11.2010, at 13:28, Paul Brook wrote: >> Makefile.objs |1 + >> default-configs/i386-softmmu.mak |1 + >> default-configs/x86_64-softmmu.mak |1 + > > > Why are you only enabling this on x86? PCI devices, especially things like > SATA controllers, should b

Re: [Qemu-devel] [PATCH 08/12] ahci: add ahci emulation

2010-11-25 Thread Paul Brook
> Makefile.objs |1 + > default-configs/i386-softmmu.mak |1 + > default-configs/x86_64-softmmu.mak |1 + Why are you only enabling this on x86? PCI devices, especially things like SATA controllers, should be completely target independent. Paul