Re: [Qemu-devel] [PATCH 08/10] ahci: add ahci emulation

2010-11-17 Thread Gerd Hoffmann
Hi, Hmm, no bus registered anywhere. Dunno whenever it makes sense to register ide bus(es) here or whenever we should create a new sata bus. I'm not sure I understand this comment :). The ahci controller should register one or more busses where you can hook up devices to via -device. Ri

Re: [Qemu-devel] [PATCH 08/10] ahci: add ahci emulation

2010-11-17 Thread Alexander Graf
On 17.11.2010, at 10:08, Gerd Hoffmann wrote: > Hi, > >> +static AHCIState *ahci_new(void) >> +{ >> +int i; >> + > >> +static int pci_ahci_init(PCIDevice *dev) >> +{ > >> +d->ahci = ahci_new(); >> +d->ahci->irq = d->card.irq[0]; >> +return 0; >> +} > > Hmm, no bus registered

Re: [Qemu-devel] [PATCH 08/10] ahci: add ahci emulation

2010-11-17 Thread Gerd Hoffmann
Hi, +static AHCIState *ahci_new(void) +{ +int i; + +static int pci_ahci_init(PCIDevice *dev) +{ +d->ahci = ahci_new(); +d->ahci->irq = d->card.irq[0]; +return 0; +} Hmm, no bus registered anywhere. Dunno whenever it makes sense to register ide bus(es) here or whenever