Re: [Qemu-devel] [PATCH 07/30] hw/arm: use the BYTE-based definitions

2018-02-15 Thread Philippe Mathieu-Daudé
On 02/15/2018 08:03 PM, Alistair Francis wrote: > On Thu, Feb 15, 2018 at 2:39 PM, Philippe Mathieu-Daudé > wrote: >> Hi Alistair, >> >> On 02/15/2018 07:31 PM, Alistair Francis wrote: >>> On Wed, Feb 14, 2018 at 8:28 PM, Philippe Mathieu-Daudé >>> wrote: It ease code review, unit is expli

Re: [Qemu-devel] [PATCH 07/30] hw/arm: use the BYTE-based definitions

2018-02-15 Thread Alistair Francis
On Thu, Feb 15, 2018 at 2:39 PM, Philippe Mathieu-Daudé wrote: > Hi Alistair, > > On 02/15/2018 07:31 PM, Alistair Francis wrote: >> On Wed, Feb 14, 2018 at 8:28 PM, Philippe Mathieu-Daudé >> wrote: >>> It ease code review, unit is explicit. >>> >>> Signed-off-by: Philippe Mathieu-Daudé >> >> T

Re: [Qemu-devel] [PATCH 07/30] hw/arm: use the BYTE-based definitions

2018-02-15 Thread Philippe Mathieu-Daudé
Hi Alistair, On 02/15/2018 07:31 PM, Alistair Francis wrote: > On Wed, Feb 14, 2018 at 8:28 PM, Philippe Mathieu-Daudé > wrote: >> It ease code review, unit is explicit. >> >> Signed-off-by: Philippe Mathieu-Daudé > > The logic looks good. > > Did you do this automatically? If so you should i

Re: [Qemu-devel] [PATCH 07/30] hw/arm: use the BYTE-based definitions

2018-02-15 Thread Alistair Francis
On Wed, Feb 14, 2018 at 8:28 PM, Philippe Mathieu-Daudé wrote: > It ease code review, unit is explicit. > > Signed-off-by: Philippe Mathieu-Daudé The logic looks good. Did you do this automatically? If so you should include the commands in the commit message. Reviewed-by: Alistair Francis Al