Re: [Qemu-devel] [PATCH 06/22] cpu: introduce CPUClass.resume() method

2013-04-10 Thread Igor Mammedov
On Tue, 09 Apr 2013 13:20:27 +0200 Paolo Bonzini wrote: > Il 08/04/2013 22:13, Eduardo Habkost ha scritto: > > So you are initializing a field of CPUClass struct inside a CPU object > > initialization function. And that's a function that is not even > > converted to QOM yet, and buried inside a n

Re: [Qemu-devel] [PATCH 06/22] cpu: introduce CPUClass.resume() method

2013-04-09 Thread Andreas Färber
Am 09.04.2013 12:26, schrieb Igor Mammedov: > On Mon, 8 Apr 2013 17:13:11 -0300 > Eduardo Habkost wrote: > >> On Fri, Apr 05, 2013 at 04:36:58PM +0200, Igor Mammedov wrote: >>> ... and call it if defined from CPUClass.realize() if CPU was hotplugged >>> >>> by default leave .resume() unset (i.e.

Re: [Qemu-devel] [PATCH 06/22] cpu: introduce CPUClass.resume() method

2013-04-09 Thread Paolo Bonzini
Il 08/04/2013 22:13, Eduardo Habkost ha scritto: > So you are initializing a field of CPUClass struct inside a CPU object > initialization function. And that's a function that is not even > converted to QOM yet, and buried inside a non-trivial function call tree > (hence easy to be called at the wr

Re: [Qemu-devel] [PATCH 06/22] cpu: introduce CPUClass.resume() method

2013-04-09 Thread Igor Mammedov
On Mon, 8 Apr 2013 17:13:11 -0300 Eduardo Habkost wrote: > On Fri, Apr 05, 2013 at 04:36:58PM +0200, Igor Mammedov wrote: > > ... and call it if defined from CPUClass.realize() if CPU was hotplugged > > > > by default leave .resume() unset (i.e. NULL) and override it for softmmu > > in qemu_init

Re: [Qemu-devel] [PATCH 06/22] cpu: introduce CPUClass.resume() method

2013-04-08 Thread Eduardo Habkost
On Fri, Apr 05, 2013 at 04:36:58PM +0200, Igor Mammedov wrote: > ... and call it if defined from CPUClass.realize() if CPU was hotplugged > > by default leave .resume() unset (i.e. NULL) and override it for softmmu > in qemu_init_vcpu() if it's still unset. > > Signed-off-by: Igor Mammedov [...]

Re: [Qemu-devel] [PATCH 06/22] cpu: introduce CPUClass.resume() method

2013-04-07 Thread li guang
Reviewed-by: liguang 在 2013-04-05五的 16:36 +0200,Igor Mammedov写道: > ... and call it if defined from CPUClass.realize() if CPU was hotplugged > > by default leave .resume() unset (i.e. NULL) and override it for softmmu > in qemu_init_vcpu() if it's still unset. > > Signed-off-by: Igor Mammedov >