Re: [Qemu-devel] [PATCH 05/11] chardev: add hmp hotplug commands

2013-01-10 Thread Luiz Capitulino
On Thu, 10 Jan 2013 11:33:35 +0100 Paolo Bonzini wrote: > Il 07/01/2013 14:55, Gerd Hoffmann ha scritto: > > +void hmp_chardev_add(Monitor *mon, const QDict *qdict) > > +{ > > +const char *args = qdict_get_str(qdict, "args"); > > +Error *err = NULL; > > +QemuOpts *opts; > > + > > +

Re: [Qemu-devel] [PATCH 05/11] chardev: add hmp hotplug commands

2013-01-10 Thread Paolo Bonzini
Il 10/01/2013 11:53, Gerd Hoffmann ha scritto: >> > >> > This ought to use qmp_chardev_add and a generic opts->ChardevBackend >> > conversion. >> > >> > But IMHO, this kind of intermediate conversion is okay, with the >> > "correct" thing deferred; being able to play with hotplug from HMP is >> >

Re: [Qemu-devel] [PATCH 05/11] chardev: add hmp hotplug commands

2013-01-10 Thread Gerd Hoffmann
On 01/10/13 11:33, Paolo Bonzini wrote: > Il 07/01/2013 14:55, Gerd Hoffmann ha scritto: >> +void hmp_chardev_add(Monitor *mon, const QDict *qdict) >> +{ >> +const char *args = qdict_get_str(qdict, "args"); >> +Error *err = NULL; >> +QemuOpts *opts; >> + >> +opts = qemu_opts_parse(q

Re: [Qemu-devel] [PATCH 05/11] chardev: add hmp hotplug commands

2013-01-10 Thread Paolo Bonzini
Il 07/01/2013 14:55, Gerd Hoffmann ha scritto: > +void hmp_chardev_add(Monitor *mon, const QDict *qdict) > +{ > +const char *args = qdict_get_str(qdict, "args"); > +Error *err = NULL; > +QemuOpts *opts; > + > +opts = qemu_opts_parse(qemu_find_opts("chardev"), args, 1); > +if (op