On 10/17/2011 04:05 PM, Kevin Wolf wrote:
> diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c
> index 347c38d..10f161f 100644
> --- a/hw/ide/atapi.c
> +++ b/hw/ide/atapi.c
> @@ -731,6 +731,8 @@ static void cmd_mode_sense(IDEState *s, uint8_t *buf)
>buf[7] = 0;
>
>/
On 10/17/2011 04:10 PM, Kevin Wolf wrote:
> Yes, the coincidence is ugly.
Maybe we should define structs for the mode pages so that you have real
names instead of just offsets into the output buffer?
Yeah, it would be nice to have a common place for all the structs
defined by the SCSI spec
Am 17.10.2011 16:04, schrieb Paolo Bonzini:
> On 10/17/2011 04:05 PM, Kevin Wolf wrote:
diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c
index 347c38d..10f161f 100644
--- a/hw/ide/atapi.c
+++ b/hw/ide/atapi.c
@@ -731,6 +731,8 @@ static void cmd_mode_sense(IDEState *s, uint
Am 13.10.2011 13:03, schrieb Paolo Bonzini:
> The page is not anymore in MMC, but at least keep the values sane.
>
> Signed-off-by: Paolo Bonzini
> ---
> hw/ide/atapi.c |2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c
> index 347c38d
