Re: [Qemu-devel] [PATCH 04/30] exec: eliminate stq_phys_notdirty

2013-05-23 Thread Peter Maydell
On 23 May 2013 20:22, Paolo Bonzini wrote: > Il 23/05/2013 19:32, Peter Maydell ha scritto: >> On 21 May 2013 11:57, Paolo Bonzini wrote: >>> > It is not used anywhere. >> So does this get deleted just because it's not used, or because >> it gets in the way of patches later in the series. > > No,

Re: [Qemu-devel] [PATCH 04/30] exec: eliminate stq_phys_notdirty

2013-05-23 Thread Paolo Bonzini
Il 23/05/2013 19:32, Peter Maydell ha scritto: > On 21 May 2013 11:57, Paolo Bonzini wrote: >> > It is not used anywhere. > So does this get deleted just because it's not used, or because > it gets in the way of patches later in the series. No, it doesn't get in the way, I just preferred to kill

Re: [Qemu-devel] [PATCH 04/30] exec: eliminate stq_phys_notdirty

2013-05-23 Thread Anthony Liguori
Peter Maydell writes: > On 21 May 2013 11:57, Paolo Bonzini wrote: >> It is not used anywhere. > > So does this get deleted just because it's not used, or because > it gets in the way of patches later in the series. As far as I > can tell the st*_phys_notdirty() are for TCG to update page > tabl

Re: [Qemu-devel] [PATCH 04/30] exec: eliminate stq_phys_notdirty

2013-05-23 Thread Peter Maydell
On 21 May 2013 11:57, Paolo Bonzini wrote: > It is not used anywhere. So does this get deleted just because it's not used, or because it gets in the way of patches later in the series. As far as I can tell the st*_phys_notdirty() are for TCG to update page table entries with accessed/modified bit