Re: [Qemu-devel] [PATCH 04/13] arm_gic: Make the GIC its own sysbus device

2012-04-13 Thread Peter Maydell
On 4 April 2012 16:30, Peter Maydell wrote: > +static Property arm_gic_properties[] = { > +    DEFINE_PROP_UINT32("num-cpu", gic_state, num_cpu, 1), > +    DEFINE_PROP_UINT32("num-irq", gic_state, num_irq, 32), > +}; Missing DEFINE_PROP_END_OF_LIST(). (This happens to only crash on a 64 bit host,

Re: [Qemu-devel] [PATCH 04/13] arm_gic: Make the GIC its own sysbus device

2012-04-04 Thread Evgeny Voevodin
On 04.04.2012 19:30, Peter Maydell wrote: Compile arm_gic.c as a standalone C file to produce a self contained sysbus GIC device. Support the legacy usage by #include of the .c file by making those users #define LEGACY_INCLUDED_GIC, so we can convert them one by one. Signed-off-by: Peter Maydell