Re: [Qemu-devel] [PATCH 03/17] iotests: ask qemu for supported formats

2018-06-07 Thread Daniel P . Berrangé
On Thu, Jun 07, 2018 at 09:50:41AM +0200, Thomas Huth wrote: > On 07.06.2018 08:57, Markus Armbruster wrote: > > Thomas Huth writes: > > > >> On 05.06.2018 00:40, Eric Blake wrote: > >>> On 06/04/2018 05:34 AM, Thomas Huth wrote: > On 04.06.2018 09:18, Markus Armbruster wrote: > > Roman

Re: [Qemu-devel] [PATCH 03/17] iotests: ask qemu for supported formats

2018-06-07 Thread Markus Armbruster
Thomas Huth writes: > On 07.06.2018 08:57, Markus Armbruster wrote: >> Thomas Huth writes: >> >>> On 05.06.2018 00:40, Eric Blake wrote: On 06/04/2018 05:34 AM, Thomas Huth wrote: > On 04.06.2018 09:18, Markus Armbruster wrote: >> Roman Kagan writes: >> >>> Add helper func

Re: [Qemu-devel] [PATCH 03/17] iotests: ask qemu for supported formats

2018-06-07 Thread Paolo Bonzini
On 07/06/2018 13:10, Thomas Huth wrote: > On 07.06.2018 13:07, Paolo Bonzini wrote: >> On 07/06/2018 09:50, Thomas Huth wrote: >>> There's no real need to kill off '?', unless it gets in the way of steering people towards 'help'. We should steer them toward 'help', because '?' is a

Re: [Qemu-devel] [PATCH 03/17] iotests: ask qemu for supported formats

2018-06-07 Thread Thomas Huth
On 07.06.2018 13:07, Paolo Bonzini wrote: > On 07/06/2018 09:50, Thomas Huth wrote: >> >>> There's no real need to kill off '?', unless it gets in the way of >>> steering people towards 'help'. We should steer them toward 'help', >>> because '?' is a trap for insufficiently sophisticated users of

Re: [Qemu-devel] [PATCH 03/17] iotests: ask qemu for supported formats

2018-06-07 Thread Paolo Bonzini
On 07/06/2018 09:50, Thomas Huth wrote: > >> There's no real need to kill off '?', unless it gets in the way of >> steering people towards 'help'. We should steer them toward 'help', >> because '?' is a trap for insufficiently sophisticated users of >> shell[*]. > ... and I agree with your points

Re: [Qemu-devel] [PATCH 03/17] iotests: ask qemu for supported formats

2018-06-07 Thread Thomas Huth
On 07.06.2018 08:57, Markus Armbruster wrote: > Thomas Huth writes: > >> On 05.06.2018 00:40, Eric Blake wrote: >>> On 06/04/2018 05:34 AM, Thomas Huth wrote: On 04.06.2018 09:18, Markus Armbruster wrote: > Roman Kagan writes: > >> Add helper functions to query the block drivers

Re: [Qemu-devel] [PATCH 03/17] iotests: ask qemu for supported formats

2018-06-06 Thread Markus Armbruster
Thomas Huth writes: > On 05.06.2018 00:40, Eric Blake wrote: >> On 06/04/2018 05:34 AM, Thomas Huth wrote: >>> On 04.06.2018 09:18, Markus Armbruster wrote: Roman Kagan writes: > Add helper functions to query the block drivers actually supported by > QEMU using "-drive format=?

Re: [Qemu-devel] [PATCH 03/17] iotests: ask qemu for supported formats

2018-06-04 Thread Thomas Huth
On 05.06.2018 00:40, Eric Blake wrote: > On 06/04/2018 05:34 AM, Thomas Huth wrote: >> On 04.06.2018 09:18, Markus Armbruster wrote: >>> Roman Kagan writes: >>> Add helper functions to query the block drivers actually supported by QEMU using "-drive format=?".  This allows to skip certai

Re: [Qemu-devel] [PATCH 03/17] iotests: ask qemu for supported formats

2018-06-04 Thread Eric Blake
On 06/04/2018 05:34 AM, Thomas Huth wrote: On 04.06.2018 09:18, Markus Armbruster wrote: Roman Kagan writes: Add helper functions to query the block drivers actually supported by QEMU using "-drive format=?". This allows to skip certain tests that require drivers not built in or whitelisted

Re: [Qemu-devel] [PATCH 03/17] iotests: ask qemu for supported formats

2018-06-04 Thread Thomas Huth
On 04.06.2018 09:18, Markus Armbruster wrote: > Roman Kagan writes: > >> Add helper functions to query the block drivers actually supported by >> QEMU using "-drive format=?". This allows to skip certain tests that >> require drivers not built in or whitelisted in QEMU. >> >> Signed-off-by: Roma

Re: [Qemu-devel] [PATCH 03/17] iotests: ask qemu for supported formats

2018-06-04 Thread Markus Armbruster
Roman Kagan writes: > Add helper functions to query the block drivers actually supported by > QEMU using "-drive format=?". This allows to skip certain tests that > require drivers not built in or whitelisted in QEMU. > > Signed-off-by: Roman Kagan > --- > tests/qemu-iotests/common.rc | 19 ++

Re: [Qemu-devel] [PATCH 03/17] iotests: ask qemu for supported formats

2018-05-30 Thread Roman Kagan
On Wed, May 30, 2018 at 02:17:55PM +0200, Max Reitz wrote: > On 2018-04-26 18:19, Roman Kagan wrote: > > @@ -550,13 +561,26 @@ def verify_cache_mode(supported_cache_modes=[]): > > if supported_cache_modes and (cachemode not in supported_cache_modes): > > notrun('not suitable for this

Re: [Qemu-devel] [PATCH 03/17] iotests: ask qemu for supported formats

2018-05-30 Thread Max Reitz
On 2018-04-26 18:19, Roman Kagan wrote: > Add helper functions to query the block drivers actually supported by > QEMU using "-drive format=?". This allows to skip certain tests that > require drivers not built in or whitelisted in QEMU. > > Signed-off-by: Roman Kagan > --- > tests/qemu-iotests