Re: [Qemu-devel] [PATCH 02/23] block: New BlockBackend

2014-09-11 Thread Markus Armbruster
Markus Armbruster writes: > Kevin Wolf writes: [...] >>> diff --git a/blockdev.c b/blockdev.c >>> index 9fbd888..86596bc 100644 >>> --- a/blockdev.c >>> +++ b/blockdev.c [...] >>> @@ -1770,7 +1778,7 @@ int do_drive_del(Monitor *mon, const QDict *qdict, >>> QObject **ret_data) >>> */ >>>

Re: [Qemu-devel] [PATCH 02/23] block: New BlockBackend

2014-09-11 Thread Markus Armbruster
Markus Armbruster writes: > Kevin Wolf writes: [...] >>> diff --git a/qemu-img.c b/qemu-img.c >>> index 4490a22..bad3f64 100644 >>> --- a/qemu-img.c >>> +++ b/qemu-img.c >> >> Won't comment on each hunk in qemu-img, but in many cases, on >> bdrv_new_open() failure, blk is leaked. > > I'll check

Re: [Qemu-devel] [PATCH 02/23] block: New BlockBackend

2014-09-11 Thread Markus Armbruster
Benoît Canet writes: > The Wednesday 10 Sep 2014 à 14:40:42 (+0200), Benoît Canet wrote : >> The Wednesday 10 Sep 2014 à 10:13:31 (+0200), Markus Armbruster wrote : [...] >> > diff --git a/qemu-img.c b/qemu-img.c >> > index 4490a22..bad3f64 100644 >> > --- a/qemu-img.c >> > +++ b/qemu-img.c >> >

Re: [Qemu-devel] [PATCH 02/23] block: New BlockBackend

2014-09-11 Thread Markus Armbruster
Benoît Canet writes: > The Wednesday 10 Sep 2014 à 10:13:31 (+0200), Markus Armbruster wrote : >> A block device consists of a frontend device model and a backend. >> >> A block backend has a tree of block drivers doing the actual work. >> The tree is managed by the block layer. >> >> We curren

Re: [Qemu-devel] [PATCH 02/23] block: New BlockBackend

2014-09-11 Thread Markus Armbruster
Benoît Canet writes: > The Wednesday 10 Sep 2014 10:13:31 (+0200), Markus Armbruster wrote : >> A block device consists of a frontend device model and a backend. >> >> A block backend has a tree of block drivers doing the actual work. >> The tree is managed by the block layer. >> >> We current

Re: [Qemu-devel] [PATCH 02/23] block: New BlockBackend

2014-09-11 Thread Markus Armbruster
Kevin Wolf writes: > Am 10.09.2014 um 10:13 hat Markus Armbruster geschrieben: >> A block device consists of a frontend device model and a backend. >> >> A block backend has a tree of block drivers doing the actual work. >> The tree is managed by the block layer. >> >> We currently use a single

Re: [Qemu-devel] [PATCH 02/23] block: New BlockBackend

2014-09-10 Thread Benoît Canet
The Wednesday 10 Sep 2014 à 14:40:42 (+0200), Benoît Canet wrote : > The Wednesday 10 Sep 2014 à 10:13:31 (+0200), Markus Armbruster wrote : > > A block device consists of a frontend device model and a backend. > > > > A block backend has a tree of block drivers doing the actual work. > > The tree

Re: [Qemu-devel] [PATCH 02/23] block: New BlockBackend

2014-09-10 Thread Benoît Canet
The Wednesday 10 Sep 2014 à 10:13:31 (+0200), Markus Armbruster wrote : > A block device consists of a frontend device model and a backend. > > A block backend has a tree of block drivers doing the actual work. > The tree is managed by the block layer. > > We currently use a single abstraction Bl

Re: [Qemu-devel] [PATCH 02/23] block: New BlockBackend

2014-09-10 Thread Benoît Canet
The Wednesday 10 Sep 2014 à 13:44:17 (+0200), Kevin Wolf wrote : > Am 10.09.2014 um 13:34 hat Benoît Canet geschrieben: > > The Wednesday 10 Sep 2014 à 10:13:31 (+0200), Markus Armbruster wrote : > > > A block device consists of a frontend device model and a backend. > > > > > > A block backend ha

Re: [Qemu-devel] [PATCH 02/23] block: New BlockBackend

2014-09-10 Thread Kevin Wolf
Am 10.09.2014 um 13:34 hat Benoît Canet geschrieben: > The Wednesday 10 Sep 2014 à 10:13:31 (+0200), Markus Armbruster wrote : > > A block device consists of a frontend device model and a backend. > > > > A block backend has a tree of block drivers doing the actual work. > > The tree is managed by

Re: [Qemu-devel] [PATCH 02/23] block: New BlockBackend

2014-09-10 Thread Benoît Canet
The Wednesday 10 Sep 2014 à 10:13:31 (+0200), Markus Armbruster wrote : > A block device consists of a frontend device model and a backend. > > A block backend has a tree of block drivers doing the actual work. > The tree is managed by the block layer. > > We currently use a single abstraction Bl

Re: [Qemu-devel] [PATCH 02/23] block: New BlockBackend

2014-09-10 Thread Kevin Wolf
Am 10.09.2014 um 10:13 hat Markus Armbruster geschrieben: > A block device consists of a frontend device model and a backend. > > A block backend has a tree of block drivers doing the actual work. > The tree is managed by the block layer. > > We currently use a single abstraction BlockDriverState