Re: [Qemu-devel] [PATCH 0/4] exec: address space translation cleanups

2017-05-17 Thread Peter Xu
On Wed, May 17, 2017 at 09:26:25AM +0200, Paolo Bonzini wrote: > > > On 17/05/2017 09:17, Maxime Coquelin wrote: > > > > > > On 05/17/2017 07:57 AM, Peter Xu wrote: > >> On Wed, May 17, 2017 at 12:23:42PM +0800, Peter Xu wrote: > >>> On Tue, May 16, 2017 at 06:51:03PM +0200, Maxime Coquelin wro

Re: [Qemu-devel] [PATCH 0/4] exec: address space translation cleanups

2017-05-17 Thread Paolo Bonzini
On 17/05/2017 09:17, Maxime Coquelin wrote: > > > On 05/17/2017 07:57 AM, Peter Xu wrote: >> On Wed, May 17, 2017 at 12:23:42PM +0800, Peter Xu wrote: >>> On Tue, May 16, 2017 at 06:51:03PM +0200, Maxime Coquelin wrote: Hi Peter, On 05/16/2017 03:24 PM, Maxime Coquelin wrote: >>>

Re: [Qemu-devel] [PATCH 0/4] exec: address space translation cleanups

2017-05-17 Thread Maxime Coquelin
On 05/17/2017 07:57 AM, Peter Xu wrote: On Wed, May 17, 2017 at 12:23:42PM +0800, Peter Xu wrote: On Tue, May 16, 2017 at 06:51:03PM +0200, Maxime Coquelin wrote: Hi Peter, On 05/16/2017 03:24 PM, Maxime Coquelin wrote: On 05/15/2017 10:50 AM, Peter Xu wrote: The problem is that, address

Re: [Qemu-devel] [PATCH 0/4] exec: address space translation cleanups

2017-05-16 Thread Peter Xu
On Wed, May 17, 2017 at 12:23:42PM +0800, Peter Xu wrote: > On Tue, May 16, 2017 at 06:51:03PM +0200, Maxime Coquelin wrote: > > Hi Peter, > > > > On 05/16/2017 03:24 PM, Maxime Coquelin wrote: > > > > > > > > >On 05/15/2017 10:50 AM, Peter Xu wrote: > > >>The problem is that, address_space_get_io

Re: [Qemu-devel] [PATCH 0/4] exec: address space translation cleanups

2017-05-16 Thread Peter Xu
On Tue, May 16, 2017 at 06:51:03PM +0200, Maxime Coquelin wrote: > Hi Peter, > > On 05/16/2017 03:24 PM, Maxime Coquelin wrote: > > > > > >On 05/15/2017 10:50 AM, Peter Xu wrote: > >>The problem is that, address_space_get_iotlb_entry() shares a lot with > >>address_space_translate(). This patch tr

Re: [Qemu-devel] [PATCH 0/4] exec: address space translation cleanups

2017-05-16 Thread Maxime Coquelin
On 05/16/2017 06:54 PM, Paolo Bonzini wrote: On 16/05/2017 18:51, Maxime Coquelin wrote: I faced the problem the old patch fixes when declaring and attaching an IOMMU device, but booting the kernel with intel_iommu=off. I tested again with patches 1 & 4 of your series, and I confirm it fix

Re: [Qemu-devel] [PATCH 0/4] exec: address space translation cleanups

2017-05-16 Thread Paolo Bonzini
On 16/05/2017 18:51, Maxime Coquelin wrote: >> >> I faced the problem the old patch fixes when declaring and attaching >> an IOMMU device, but booting the kernel with intel_iommu=off. >> >> I tested again with patches 1 & 4 of your series, and I confirm it >> fixes the issue: >> Tested-by: Maxime

Re: [Qemu-devel] [PATCH 0/4] exec: address space translation cleanups

2017-05-16 Thread Maxime Coquelin
Hi Peter, On 05/16/2017 03:24 PM, Maxime Coquelin wrote: On 05/15/2017 10:50 AM, Peter Xu wrote: The problem is that, address_space_get_iotlb_entry() shares a lot with address_space_translate(). This patch tries to abstract the shared elements. Originally, this work is derived from discussio

Re: [Qemu-devel] [PATCH 0/4] exec: address space translation cleanups

2017-05-16 Thread Maxime Coquelin
On 05/15/2017 10:50 AM, Peter Xu wrote: The problem is that, address_space_get_iotlb_entry() shares a lot with address_space_translate(). This patch tries to abstract the shared elements. Originally, this work is derived from discussion from VT-d passthrough series discussions [1]. But for sur