Re: [Qemu-devel] [PATCH 0/2] fix segfault in (iscsi) option parsing

2013-03-19 Thread Paolo Bonzini
Il 19/03/2013 20:37, Peter Lieven ha scritto: > > Am 19.03.2013 um 18:07 schrieb Paolo Bonzini : > >> Il 19/03/2013 16:54, Peter Lieven ha scritto: >>> On 19.03.2013 12:18, Paolo Bonzini wrote: Il 19/03/2013 09:51, Markus Armbruster ha scritto: > Paolo, please have a look. Why isn't

Re: [Qemu-devel] [PATCH 0/2] fix segfault in (iscsi) option parsing

2013-03-19 Thread Peter Lieven
Am 19.03.2013 um 18:07 schrieb Paolo Bonzini : > Il 19/03/2013 16:54, Peter Lieven ha scritto: >> On 19.03.2013 12:18, Paolo Bonzini wrote: >>> Il 19/03/2013 09:51, Markus Armbruster ha scritto: Paolo, please have a look. >>> Why isn't it enough to call bdrv_init_with_whitelist earlier? >>>

Re: [Qemu-devel] [PATCH 0/2] fix segfault in (iscsi) option parsing

2013-03-19 Thread Paolo Bonzini
Il 19/03/2013 16:54, Peter Lieven ha scritto: > On 19.03.2013 12:18, Paolo Bonzini wrote: >> Il 19/03/2013 09:51, Markus Armbruster ha scritto: >>> Paolo, please have a look. >> Why isn't it enough to call bdrv_init_with_whitelist earlier? >> >> There is no conditional logic in it, the whitelist is

Re: [Qemu-devel] [PATCH 0/2] fix segfault in (iscsi) option parsing

2013-03-19 Thread Peter Lieven
On 19.03.2013 12:18, Paolo Bonzini wrote: Il 19/03/2013 09:51, Markus Armbruster ha scritto: Paolo, please have a look. Why isn't it enough to call bdrv_init_with_whitelist earlier? There is no conditional logic in it, the whitelist is checked at open time. Has anyone tested if -spice is wor

Re: [Qemu-devel] [PATCH 0/2] fix segfault in (iscsi) option parsing

2013-03-19 Thread Paolo Bonzini
Il 19/03/2013 09:51, Markus Armbruster ha scritto: > Paolo, please have a look. Why isn't it enough to call bdrv_init_with_whitelist earlier? There is no conditional logic in it, the whitelist is checked at open time. Paolo > Peter Lieven writes: > >> current git master segfaults if an iscsi

Re: [Qemu-devel] [PATCH 0/2] fix segfault in (iscsi) option parsing

2013-03-19 Thread Markus Armbruster
Paolo, please have a look. Peter Lieven writes: > current git master segfaults if an iscsi option is specified > in command line. > > Peter Lieven (2): > qemu-option: avoid segfault if QemuOptsList == NULL > vl.c: fix segfault in iscsi options parsing > > block/iscsi.c | 27 -