Re: [Qemu-devel] [PATCH]target-i386:cpu_x86_init():do clean up work

2012-12-02 Thread li guang
在 2012-11-29四的 16:34 -0200,Eduardo Habkost写道: > On Wed, Nov 28, 2012 at 02:20:23PM +0800, liguang wrote: > > 1.remove unused variable env > > It's not unused. You are removing the line that sets env->cpu_model_str. > > > 2.remove redundant error handling > > > > Signed-off-by: liguang > > --- >

Re: [Qemu-devel] [PATCH]target-i386:cpu_x86_init():do clean up work

2012-11-29 Thread Eduardo Habkost
On Wed, Nov 28, 2012 at 02:20:23PM +0800, liguang wrote: > 1.remove unused variable env It's not unused. You are removing the line that sets env->cpu_model_str. > 2.remove redundant error handling > > Signed-off-by: liguang > --- > target-i386/helper.c | 17 - > 1 files chang