Re: [Qemu-devel] [PATCH] vt82c686: avoid out-of-bounds read

2014-12-11 Thread zhanghailiang
On 2014/12/10 17:17, Paolo Bonzini wrote: superio_ioport_readb can read the 256th element of the array. Coverity reports an out-of-bounds write in superio_ioport_writeb, but it does not show the corresponding out-of-bounds read because it cannot prove that it can happen. Fix the root cause of th

Re: [Qemu-devel] [PATCH] vt82c686: avoid out-of-bounds read

2014-12-10 Thread Paolo Bonzini
On 10/12/2014 10:31, zhanghailiang wrote: > Hi paolo, > > Will this change affects the migration? > I noticed that there is a member 'SuperIOConfig superio_conf' in > VT82C686BState. > > vt82c686 seems only to be used in mips64el target, Do we support > migration for mips target? No, there is

Re: [Qemu-devel] [PATCH] vt82c686: avoid out-of-bounds read

2014-12-10 Thread zhanghailiang
Hi paolo, Will this change affects the migration? I noticed that there is a member 'SuperIOConfig superio_conf' in VT82C686BState. vt82c686 seems only to be used in mips64el target, Do we support migration for mips target? Thanks, zhanghailiang On 2014/12/10 17:17, Paolo Bonzini wrote: super