Re: [Qemu-devel] [PATCH] virtio-net: don't update mac_table in error state

2013-11-19 Thread Stefan Hajnoczi
On Mon, Nov 11, 2013 at 11:48:36AM +0800, Amos Kong wrote: > mac_table was always cleaned up first in handling > VIRTIO_NET_CTRL_MAC_TABLE_SET command, and we din't recover > mac_table content in error state, it's not correct. > > This patch makes all the changes in temporal variables, > only upda

Re: [Qemu-devel] [PATCH] virtio-net: don't update mac_table in error state

2013-11-12 Thread Jason Wang
On 11/11/2013 11:48 AM, Amos Kong wrote: > mac_table was always cleaned up first in handling > VIRTIO_NET_CTRL_MAC_TABLE_SET command, and we din't recover > mac_table content in error state, it's not correct. > > This patch makes all the changes in temporal variables, > only update the real mac_tab

Re: [Qemu-devel] [PATCH] virtio-net: don't update mac_table in error state

2013-11-12 Thread Vlad Yasevich
On 11/10/2013 10:48 PM, Amos Kong wrote: mac_table was always cleaned up first in handling VIRTIO_NET_CTRL_MAC_TABLE_SET command, and we din't recover mac_table content in error state, it's not correct. This patch makes all the changes in temporal variables, only update the real mac_table if eve