Re: [Qemu-devel] [PATCH] virtio-net: Make virtio queue sizes configurable

2016-03-15 Thread Patrik Hermansson
Hi Michael Thanks for looking into the patch and for your comments. 2016-03-15 5:50 GMT+01:00 Michael S. Tsirkin : > On Fri, Nov 27, 2015 at 04:02:39PM +0100, Patrik Hermansson wrote: >> This patch adds the option to specify virtio queue sizes. Currently the >> queue sizes is hard coded to 256, w

Re: [Qemu-devel] [PATCH] virtio-net: Make virtio queue sizes configurable

2016-03-15 Thread Michael S. Tsirkin
On Tue, Mar 15, 2016 at 09:00:39AM +0100, Greg Kurz wrote: > On Tue, 15 Mar 2016 06:50:38 +0200 > "Michael S. Tsirkin" wrote: > > > On Fri, Nov 27, 2015 at 04:02:39PM +0100, Patrik Hermansson wrote: > > > This patch adds the option to specify virtio queue sizes. Currently the > > > queue sizes is

Re: [Qemu-devel] [PATCH] virtio-net: Make virtio queue sizes configurable

2016-03-15 Thread Patrik Hermansson
Hi Greg, Thanks for your comments and for taking the time. 2016-03-14 12:27 GMT+01:00 Greg Kurz : > > SoB tag is missing. I will add this in the future. > > +static void virtio_net_validate_queue_limit(uint16_t *queue_size) > > +{ > > +if (*queue_size > VIRTIO_QUEUE_SIZE_MAX) { > > +

Re: [Qemu-devel] [PATCH] virtio-net: Make virtio queue sizes configurable

2016-03-15 Thread Greg Kurz
On Tue, 15 Mar 2016 06:50:38 +0200 "Michael S. Tsirkin" wrote: > On Fri, Nov 27, 2015 at 04:02:39PM +0100, Patrik Hermansson wrote: > > This patch adds the option to specify virtio queue sizes. Currently the > > queue sizes is hard coded to 256, which might not be suitable for all types > > of ap

Re: [Qemu-devel] [PATCH] virtio-net: Make virtio queue sizes configurable

2016-03-15 Thread Greg Kurz
On Mon, 14 Mar 2016 12:27:55 +0100 Greg Kurz wrote: > On Fri, 27 Nov 2015 16:02:39 +0100 > Patrik Hermansson wrote: > > > This patch adds the option to specify virtio queue sizes. Currently the > > queue sizes is hard coded to 256, which might not be suitable for all types > > of applications.

Re: [Qemu-devel] [PATCH] virtio-net: Make virtio queue sizes configurable

2016-03-14 Thread Michael S. Tsirkin
On Fri, Nov 27, 2015 at 04:02:39PM +0100, Patrik Hermansson wrote: > This patch adds the option to specify virtio queue sizes. Currently the > queue sizes is hard coded to 256, which might not be suitable for all types > of applications. Any more data here? 256 packets seems plenty. Is there a cha

Re: [Qemu-devel] [PATCH] virtio-net: Make virtio queue sizes configurable

2016-03-14 Thread Greg Kurz
On Fri, 27 Nov 2015 16:02:39 +0100 Patrik Hermansson wrote: > This patch adds the option to specify virtio queue sizes. Currently the > queue sizes is hard coded to 256, which might not be suitable for all types > of applications. This patch makes it possible to specify the queue size > between