Re: [Qemu-devel] [PATCH] virtio: avoid leading underscores for helpers

2015-03-10 Thread Cornelia Huck
On Tue, 10 Mar 2015 17:34:27 +0100 "Michael S. Tsirkin" wrote: > On Tue, Mar 10, 2015 at 05:03:47PM +0100, Cornelia Huck wrote: > > On Tue, 10 Mar 2015 15:27:24 +0100 > > "Michael S. Tsirkin" wrote: > > > > > On Tue, Mar 10, 2015 at 03:22:29PM +0100, Cornelia Huck wrote: > > > > On Tue, 10 Mar

Re: [Qemu-devel] [PATCH] virtio: avoid leading underscores for helpers

2015-03-10 Thread Michael S. Tsirkin
On Tue, Mar 10, 2015 at 05:03:47PM +0100, Cornelia Huck wrote: > On Tue, 10 Mar 2015 15:27:24 +0100 > "Michael S. Tsirkin" wrote: > > > On Tue, Mar 10, 2015 at 03:22:29PM +0100, Cornelia Huck wrote: > > > On Tue, 10 Mar 2015 15:12:14 +0100 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Tue,

Re: [Qemu-devel] [PATCH] virtio: avoid leading underscores for helpers

2015-03-10 Thread Cornelia Huck
On Tue, 10 Mar 2015 15:27:24 +0100 "Michael S. Tsirkin" wrote: > On Tue, Mar 10, 2015 at 03:22:29PM +0100, Cornelia Huck wrote: > > On Tue, 10 Mar 2015 15:12:14 +0100 > > "Michael S. Tsirkin" wrote: > > > > > On Tue, Mar 10, 2015 at 02:32:15PM +0100, Cornelia Huck wrote: > > > > Commit ef546f12

Re: [Qemu-devel] [PATCH] virtio: avoid leading underscores for helpers

2015-03-10 Thread Michael S. Tsirkin
On Tue, Mar 10, 2015 at 03:22:29PM +0100, Cornelia Huck wrote: > On Tue, 10 Mar 2015 15:12:14 +0100 > "Michael S. Tsirkin" wrote: > > > On Tue, Mar 10, 2015 at 02:32:15PM +0100, Cornelia Huck wrote: > > > Commit ef546f1275f6563e8934dd5e338d29d9f9909ca6 ("virtio: add > > > feature checking helpers

Re: [Qemu-devel] [PATCH] virtio: avoid leading underscores for helpers

2015-03-10 Thread Michael S. Tsirkin
On Tue, Mar 10, 2015 at 02:32:15PM +0100, Cornelia Huck wrote: > Commit ef546f1275f6563e8934dd5e338d29d9f9909ca6 ("virtio: add > feature checking helpers") introduced a helper __virtio_has_feature. > We don't want to use reserved identifiers, though, so let's > rename __virtio_has_feature to virtio

Re: [Qemu-devel] [PATCH] virtio: avoid leading underscores for helpers

2015-03-10 Thread Cornelia Huck
On Tue, 10 Mar 2015 15:12:14 +0100 "Michael S. Tsirkin" wrote: > On Tue, Mar 10, 2015 at 02:32:15PM +0100, Cornelia Huck wrote: > > Commit ef546f1275f6563e8934dd5e338d29d9f9909ca6 ("virtio: add > > feature checking helpers") introduced a helper __virtio_has_feature. > > We don't want to use reser