Re: [Qemu-devel] [PATCH] vhost-user: don't poke at chardev internal QemuOpts

2016-10-07 Thread Marc-André Lureau
On Fri, Oct 7, 2016 at 1:15 PM Daniel P. Berrange wrote: > On Fri, Oct 07, 2016 at 09:10:27AM +, Marc-André Lureau wrote: > > Hi > > > > On Fri, Oct 7, 2016 at 1:04 PM Daniel P. Berrange > > wrote: > > > > > The vhost-user code is poking at the QemuOpts instance > > > in the CharDriverState

Re: [Qemu-devel] [PATCH] vhost-user: don't poke at chardev internal QemuOpts

2016-10-07 Thread Daniel P. Berrange
On Fri, Oct 07, 2016 at 09:10:27AM +, Marc-André Lureau wrote: > Hi > > On Fri, Oct 7, 2016 at 1:04 PM Daniel P. Berrange > wrote: > > > The vhost-user code is poking at the QemuOpts instance > > in the CharDriverState struct, not realizing that it is > > valid for this to be NULL. e.g. the

Re: [Qemu-devel] [PATCH] vhost-user: don't poke at chardev internal QemuOpts

2016-10-07 Thread Marc-André Lureau
Hi On Fri, Oct 7, 2016 at 1:04 PM Daniel P. Berrange wrote: > The vhost-user code is poking at the QemuOpts instance > in the CharDriverState struct, not realizing that it is > valid for this to be NULL. e.g. the following crash > shows a codepath where it will be NULL: > > Program terminated w