Re: [Qemu-devel] [PATCH] util: Add 'static' attribute to function implementation

2014-03-17 Thread Richard Henderson
On 03/16/2014 11:42 AM, Stefan Weil wrote: > We have a similar situation with other attributes, too. Smatch also > complains about missing QEMU_NORETURN in our implementation code (we add > it only in header files for global functions). Do you think it would be > good to make header and implementat

Re: [Qemu-devel] [PATCH] util: Add 'static' attribute to function implementation

2014-03-16 Thread Stefan Weil
Am 16.03.2014 19:06, schrieb Richard Henderson: > On 03/16/2014 11:02 AM, Stefan Weil wrote: >> 'static' is used in the forward declaration, but not in the implementation. >> Add it there, too. > > You might consider reporting this as a bug in the analyzer, since the static > in > the forward dec

Re: [Qemu-devel] [PATCH] util: Add 'static' attribute to function implementation

2014-03-16 Thread Richard Henderson
On 03/16/2014 11:02 AM, Stefan Weil wrote: > 'static' is used in the forward declaration, but not in the implementation. > Add it there, too. You might consider reporting this as a bug in the analyzer, since the static in the forward declaration does apply to the definition. That said, for style