Re: [Qemu-devel] [PATCH] tcg/mips: make some functions inline.

2017-11-03 Thread Richard Henderson
On 11/03/2017 01:37 AM, jiang.bi...@zte.com.cn wrote: >> On 11/02/2017 12:23 PM, jiang.bi...@zte.com.cn wrote: >>> No, :) Just found some of these functions are inline and others are not >>> when reading >>> the code, the style looks inconsistent. >>> >> My preference would be to remove them all.

Re: [Qemu-devel] [PATCH] tcg/mips: make some functions inline.

2017-11-02 Thread jiang.biao2
> On 11/02/2017 12:23 PM, jiang.bi...@zte.com.cn wrote: > > No, :) Just found some of these functions are inline and others are not > > when reading > > the code, the style looks inconsistent. > > > My preference would be to remove them all. Should I commit another patch to do that? :) > > Besid

Re: [Qemu-devel] [PATCH] tcg/mips: make some functions inline.

2017-11-02 Thread Philippe Mathieu-Daudé
On Thu, Nov 2, 2017 at 8:43 AM, Richard Henderson wrote: > On 11/02/2017 12:23 PM, jiang.bi...@zte.com.cn wrote: >> No, :) Just found some of these functions are inline and others are not when >> reading >> the code, the style looks inconsistent. > > My preference would be to remove them all. If

Re: [Qemu-devel] [PATCH] tcg/mips: make some functions inline.

2017-11-02 Thread Richard Henderson
On 11/02/2017 12:23 PM, jiang.bi...@zte.com.cn wrote: > No, :) Just found some of these functions are inline and others are not when > reading > the code, the style looks inconsistent. My preference would be to remove them all. > Besides, The compiler may make default inline choices for some f

Re: [Qemu-devel] [PATCH] tcg/mips: make some functions inline.

2017-11-02 Thread jiang.biao2
> On 11/02/2017 11:26 AM, Jiang Biao wrote:> > Make some functions inline. > > Why? > > Do you have evidence that the compiler isn't making reasonable default choices > with respect to inlining? No, :) Just found some of these functions are inline and others are not when reading the code, the s

Re: [Qemu-devel] [PATCH] tcg/mips: make some functions inline.

2017-11-02 Thread Richard Henderson
On 11/02/2017 11:26 AM, Jiang Biao wrote: > Make some functions inline. Why? Do you have evidence that the compiler isn't making reasonable default choices with respect to inlining? r~