Re: [Qemu-devel] [PATCH] syscall: fix compiler warnings (clang 5)

2017-05-10 Thread Eric Blake
>> >> The "for" loop scans the structure to find the rt_dev field, and we >> should always enter in the first "if", so "host_rt_dev_ptr" is always >> set. > > It's better indeed, I'll use g_assert_nonnull() and resend. Careful - we haven't yet resolved whether g_assert_nonnull() is safe to use.

Re: [Qemu-devel] [PATCH] syscall: fix compiler warnings (clang 5)

2017-05-10 Thread Philippe Mathieu-Daudé
On 05/10/2017 09:32 AM, Laurent Vivier wrote: On 06/05/2017 02:41, Philippe Mathieu-Daudé wrote: static code analyzer complain: linux-user/syscall.c:5575:9: warning: Dereference of undefined pointer value if (*host_rt_dev_ptr != 0) { ^~~~ Reported-by: Clang Static Analy

Re: [Qemu-devel] [PATCH] syscall: fix compiler warnings (clang 5)

2017-05-10 Thread Laurent Vivier
On 06/05/2017 02:41, Philippe Mathieu-Daudé wrote: > static code analyzer complain: > > linux-user/syscall.c:5575:9: warning: Dereference of undefined pointer value > if (*host_rt_dev_ptr != 0) { > ^~~~ > > Reported-by: Clang Static Analyzer > Signed-off-by: Philippe Mathi