Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2014-04-14 Thread Alexander Graf
On 10.02.14 06:12, Alexey Kardashevskiy wrote: On 02/08/2014 01:06 AM, Alexander Graf wrote: On 07.02.2014, at 14:44, Greg Kurz wrote: In the past, IO space could not be mapped into the memory address space so we introduced a workaround for that. Nowadays it does not look necessary so we can

Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2014-02-09 Thread Alexey Kardashevskiy
On 02/08/2014 01:06 AM, Alexander Graf wrote: > > On 07.02.2014, at 14:44, Greg Kurz wrote: > >> In the past, IO space could not be mapped into the memory address space >> so we introduced a workaround for that. Nowadays it does not look >> necessary so we can remove the workaround and make sPAP

Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2014-02-07 Thread Alexander Graf
On 07.02.2014, at 14:44, Greg Kurz wrote: > In the past, IO space could not be mapped into the memory address space > so we introduced a workaround for that. Nowadays it does not look > necessary so we can remove the workaround and make sPAPR PCI > configuration simplier. > > Signed-off-by: Gre

Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2014-01-06 Thread Alexey Kardashevskiy
On 01/06/2014 10:12 PM, Greg Kurz wrote: > On Fri, 03 Jan 2014 09:08:21 +1100 > Alexey Kardashevskiy wrote: >> >> Please read the rest of this thread. It does not visibly break things but >> with this patch QEMU starts calling unassigned_mem_accepts() (normally >> silent) which is not a good sign.

Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2014-01-06 Thread Greg Kurz
On Fri, 03 Jan 2014 09:08:21 +1100 Alexey Kardashevskiy wrote: > > Please read the rest of this thread. It does not visibly break things but > with this patch QEMU starts calling unassigned_mem_accepts() (normally > silent) which is not a good sign. > > > Hmm... this is only because this patc

Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2014-01-02 Thread Alexey Kardashevskiy
On 03.01.2014 9:09, Alexander Graf wrote: > > On 02.01.2014, at 23:08, Alexey Kardashevskiy wrote: > >> On 01/03/2014 08:04 AM, Alexander Graf wrote: >>> >>> On 11.12.2013, at 07:47, Alexey Kardashevskiy wrote: >>> On 12/10/2013 06:47 PM, Greg Kurz wrote: > On Tue, 10 Dec 2013 13:43:05

Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2014-01-02 Thread Alexander Graf
On 02.01.2014, at 23:08, Alexey Kardashevskiy wrote: > On 01/03/2014 08:04 AM, Alexander Graf wrote: >> >> On 11.12.2013, at 07:47, Alexey Kardashevskiy wrote: >> >>> On 12/10/2013 06:47 PM, Greg Kurz wrote: On Tue, 10 Dec 2013 13:43:05 +1100 Alexey Kardashevskiy wrote: > On 12

Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2014-01-02 Thread Alexey Kardashevskiy
On 01/03/2014 08:04 AM, Alexander Graf wrote: > > On 11.12.2013, at 07:47, Alexey Kardashevskiy wrote: > >> On 12/10/2013 06:47 PM, Greg Kurz wrote: >>> On Tue, 10 Dec 2013 13:43:05 +1100 >>> Alexey Kardashevskiy wrote: On 12/10/2013 03:33 AM, Greg Kurz wrote: > In the past, IO space c

Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2014-01-02 Thread Alexander Graf
On 11.12.2013, at 07:47, Alexey Kardashevskiy wrote: > On 12/10/2013 06:47 PM, Greg Kurz wrote: >> On Tue, 10 Dec 2013 13:43:05 +1100 >> Alexey Kardashevskiy wrote: >>> On 12/10/2013 03:33 AM, Greg Kurz wrote: In the past, IO space could not be mapped into the memory address space so

Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2013-12-17 Thread Alexey Kardashevskiy
On 12/17/2013 06:52 PM, Greg Kurz wrote: > On Wed, 11 Dec 2013 18:07:58 +1100 > Alexey Kardashevskiy wrote: >> >> Hm. Nack. This fails: >> >> ./qemu-system-ppc64 \ >> -trace "events=qemu_trace_events" \ >> -L "qemu-ppc64-bios/" \ >> -nographic \ >> -vga "none" \ >> -device \ >> virtio-blk-pc

Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2013-12-16 Thread Greg Kurz
On Wed, 11 Dec 2013 18:07:58 +1100 Alexey Kardashevskiy wrote: > > Hm. Nack. This fails: > > ./qemu-system-ppc64 \ > -trace "events=qemu_trace_events" \ > -L "qemu-ppc64-bios/" \ > -nographic \ > -vga "none" \ > -device \ > virtio-blk-pci,id=virtioiblk0,drive=drive0,bootindex=20,ioeventfd=

Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2013-12-10 Thread Alexey Kardashevskiy
On 12/11/2013 05:47 PM, Alexey Kardashevskiy wrote: > On 12/10/2013 06:47 PM, Greg Kurz wrote: >> On Tue, 10 Dec 2013 13:43:05 +1100 >> Alexey Kardashevskiy wrote: >>> On 12/10/2013 03:33 AM, Greg Kurz wrote: In the past, IO space could not be mapped into the memory address space so we i

Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2013-12-10 Thread Alexey Kardashevskiy
On 12/10/2013 06:47 PM, Greg Kurz wrote: > On Tue, 10 Dec 2013 13:43:05 +1100 > Alexey Kardashevskiy wrote: >> On 12/10/2013 03:33 AM, Greg Kurz wrote: >>> In the past, IO space could not be mapped into the memory address space >>> so we introduced a workaround for that. Nowadays it does not look

Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2013-12-09 Thread Greg Kurz
On Tue, 10 Dec 2013 13:43:05 +1100 Alexey Kardashevskiy wrote: > On 12/10/2013 03:33 AM, Greg Kurz wrote: > > In the past, IO space could not be mapped into the memory address space > > so we introduced a workaround for that. Nowadays it does not look > > necessary so we can remove the workaround

Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2013-12-09 Thread Alexey Kardashevskiy
On 12/10/2013 03:33 AM, Greg Kurz wrote: > In the past, IO space could not be mapped into the memory address space > so we introduced a workaround for that. Nowadays it does not look > necessary so we can remove the workaround and make sPAPR PCI > configuration simplier. > > This workaround has al

Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2013-07-16 Thread Alexey Kardashevskiy
On 07/16/2013 07:01 PM, Alexander Graf wrote: > > > Am 16.07.2013 um 10:45 schrieb Benjamin Herrenschmidt > : > >> On Tue, 2013-07-16 at 10:32 +0200, Alexander Graf wrote: > Did I miss anything here? No, I don't think so. The patch looks good. >>> >>> ... and will break all Mac

Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2013-07-16 Thread Alexander Graf
Am 16.07.2013 um 10:45 schrieb Benjamin Herrenschmidt : > On Tue, 2013-07-16 at 10:32 +0200, Alexander Graf wrote: Did I miss anything here? >>> >>> No, I don't think so. The patch looks good. >> >> ... and will break all Mac targets again, no? Not to speak of non-ppc >> devices. > > D

Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2013-07-16 Thread Benjamin Herrenschmidt
On Tue, 2013-07-16 at 10:32 +0200, Alexander Graf wrote: > >> Did I miss anything here? > > > > No, I don't think so. The patch looks good. > > ... and will break all Mac targets again, no? Not to speak of non-ppc > devices. Do you know why it breaks ? Can you suggest what's wrong and how to fi

Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2013-07-16 Thread Alexander Graf
Am 16.07.2013 um 10:37 schrieb Alexey Kardashevskiy : > On 07/16/2013 06:32 PM, Alexander Graf wrote: >> >> >> Am 16.07.2013 um 08:20 schrieb Paolo Bonzini : >> >>> Il 16/07/2013 07:19, Alexey Kardashevskiy ha scritto: In the past, IO space could not be mapped into the memory address spa

Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2013-07-16 Thread Alexey Kardashevskiy
On 07/16/2013 06:32 PM, Alexander Graf wrote: > > > Am 16.07.2013 um 08:20 schrieb Paolo Bonzini : > >> Il 16/07/2013 07:19, Alexey Kardashevskiy ha scritto: >>> In the past, IO space could not be mapped into the memory address space >>> so we introduced a workaround for that. Nowadays it does n

Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2013-07-16 Thread Alexander Graf
Am 16.07.2013 um 08:20 schrieb Paolo Bonzini : > Il 16/07/2013 07:19, Alexey Kardashevskiy ha scritto: >> In the past, IO space could not be mapped into the memory address space >> so we introduced a workaround for that. Nowadays it does not look >> necessary so we can remove the workaround and

Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2013-07-15 Thread Paolo Bonzini
Il 16/07/2013 07:19, Alexey Kardashevskiy ha scritto: > In the past, IO space could not be mapped into the memory address space > so we introduced a workaround for that. Nowadays it does not look > necessary so we can remove the workaround and make sPAPR PCI > configuration simplier. > > This also

Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2013-07-15 Thread Alexey Kardashevskiy
On 07/15/2013 04:06 PM, Alexander Graf wrote: > > On 15.07.2013, at 05:24, Alexey Kardashevskiy wrote: > >> As it looks like all portio users have migrated to new portio api, >> the workaround with memory access to io ports routing is no more >> needed. >> >> This also fixes a bug with byte swapp

Re: [Qemu-devel] [PATCH] spapr-pci: remove io ports workaround

2013-07-14 Thread Alexander Graf
On 15.07.2013, at 05:24, Alexey Kardashevskiy wrote: > As it looks like all portio users have migrated to new portio api, > the workaround with memory access to io ports routing is no more > needed. > > This also fixes a bug with byte swapping as the io region was marked > as little endian while