Re: [Qemu-devel] [PATCH] slirp: Allow to disable IPv4 or IPv6

2016-03-23 Thread Daniel P. Berrange
On Sun, Mar 20, 2016 at 12:39:14PM +0100, Samuel Thibault wrote: > Make net=0.0.0.0 disable IPv4 and ip6-net=:: disable IPv6, so the user can > setup IPv4-only and IPv6-only network environments. I really don't like this kind of magic because it is totally invisible to the user unless they read th

Re: [Qemu-devel] [PATCH] slirp: Allow to disable IPv4 or IPv6

2016-03-23 Thread Markus Armbruster
Samuel Thibault writes: > Hello, > > Markus Armbruster, on Mon 21 Mar 2016 08:33:52 +0100, wrote: >> > -# @net: #optional IP address and optional netmask >> > +# @net: #optional IP address and optional netmask. Set to 0.0.0.0 to >> > disable IPv4 completely >> >> Long line. >> >> Syntax? Defa

Re: [Qemu-devel] [PATCH] slirp: Allow to disable IPv4 or IPv6

2016-03-22 Thread Samuel Thibault
Hello, Markus Armbruster, on Mon 21 Mar 2016 08:33:52 +0100, wrote: > > -# @net: #optional IP address and optional netmask > > +# @net: #optional IP address and optional netmask. Set to 0.0.0.0 to > > disable IPv4 completely > > Long line. > > Syntax? Default value? Something like this? # @n

Re: [Qemu-devel] [PATCH] slirp: Allow to disable IPv4 or IPv6

2016-03-22 Thread Thomas Huth
On 22.03.2016 08:41, Markus Armbruster wrote: > Samuel Thibault writes: > >> Markus Armbruster, on Mon 21 Mar 2016 08:33:52 +0100, wrote: >>> Samuel Thibault writes: Make net=0.0.0.0 disable IPv4 and ip6-net=:: disable IPv6, so the user can setup IPv4-only and IPv6-only network environ

Re: [Qemu-devel] [PATCH] slirp: Allow to disable IPv4 or IPv6

2016-03-22 Thread Markus Armbruster
Samuel Thibault writes: > Markus Armbruster, on Mon 21 Mar 2016 08:33:52 +0100, wrote: >> Samuel Thibault writes: >> > Make net=0.0.0.0 disable IPv4 and ip6-net=:: disable IPv6, so the user can >> > setup IPv4-only and IPv6-only network environments. >> >> Do "net=" and "ip6-net=" mean anything

Re: [Qemu-devel] [PATCH] slirp: Allow to disable IPv4 or IPv6

2016-03-21 Thread Samuel Thibault
Markus Armbruster, on Mon 21 Mar 2016 08:33:52 +0100, wrote: > Samuel Thibault writes: > > Make net=0.0.0.0 disable IPv4 and ip6-net=:: disable IPv6, so the user can > > setup IPv4-only and IPv6-only network environments. > > Do "net=" and "ip6-net=" mean anything useful? If not, wouldn't that b

Re: [Qemu-devel] [PATCH] slirp: Allow to disable IPv4 or IPv6

2016-03-21 Thread Markus Armbruster
Samuel Thibault writes: > Markus Armbruster, on Mon 21 Mar 2016 08:33:52 +0100, wrote: >> > +either in the form a.b.c.d or as number of valid top-most bits. Set to >> > 0.0.0.0 >> > +to disable IPv4 completely. Default is 10.0.2.0/24. >> >> Long line. > > How long is too long? This is 78 charac

Re: [Qemu-devel] [PATCH] slirp: Allow to disable IPv4 or IPv6

2016-03-21 Thread Samuel Thibault
Markus Armbruster, on Mon 21 Mar 2016 08:33:52 +0100, wrote: > > +either in the form a.b.c.d or as number of valid top-most bits. Set to > > 0.0.0.0 > > +to disable IPv4 completely. Default is 10.0.2.0/24. > > Long line. How long is too long? This is 78 characters, and I see plenty of lines beyo

Re: [Qemu-devel] [PATCH] slirp: Allow to disable IPv4 or IPv6

2016-03-21 Thread Markus Armbruster
Samuel Thibault writes: > Make net=0.0.0.0 disable IPv4 and ip6-net=:: disable IPv6, so the user can > setup IPv4-only and IPv6-only network environments. Do "net=" and "ip6-net=" mean anything useful? If not, wouldn't that be a more natural way to switch off than abusing the wildcard address?

Re: [Qemu-devel] [PATCH] slirp: Allow to disable IPv4 or IPv6

2016-03-21 Thread Thomas Huth
On 20.03.2016 12:39, Samuel Thibault wrote: > Make net=0.0.0.0 disable IPv4 and ip6-net=:: disable IPv6, so the user can > setup IPv4-only and IPv6-only network environments. > > Signed-off-by: Samuel Thibault > --- > net/slirp.c | 8 +--- > qapi-schema.json | 4 ++-- > qemu-options

Re: [Qemu-devel] [PATCH] slirp: Allow to disable IPv4 or IPv6

2016-03-20 Thread Samuel Thibault
Samuel Thibault, on Sun 20 Mar 2016 12:39:14 +0100, wrote: > void icmp6_init(Slirp *slirp) > { > +if (in6_zero(&slirp->vprefix_addr6)) { > +/* IPv6 is disabled */ > +return; > +} > + (Note: vprefix_addr6 is not actually initialized yet at that point, which poses problem,