Re: [Qemu-devel] [PATCH] replay: wake up vCPU when replaying

2018-09-11 Thread Paolo Bonzini
On 11/09/2018 09:37, Pavel Dovgalyuk wrote: >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] >> On 09/07/2018 13:24, Pavel Dovgalyuk wrote: >>> static void qemu_tcg_rr_wait_io_event(CPUState *cpu) >>> { >>> while (all_cpu_threads_idle()) { >>> stop_tcg_kick_timer(); >>> qemu_

Re: [Qemu-devel] [PATCH] replay: wake up vCPU when replaying

2018-09-11 Thread Pavel Dovgalyuk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > On 09/07/2018 13:24, Pavel Dovgalyuk wrote: > > static void qemu_tcg_rr_wait_io_event(CPUState *cpu) > > { > > while (all_cpu_threads_idle()) { > > stop_tcg_kick_timer(); > > qemu_cond_wait(cpu->halt_cond, &qemu_global_mutex);

Re: [Qemu-devel] [PATCH] replay: wake up vCPU when replaying

2018-09-10 Thread Paolo Bonzini
On 09/07/2018 13:24, Pavel Dovgalyuk wrote: > static void qemu_tcg_rr_wait_io_event(CPUState *cpu) > { > while (all_cpu_threads_idle()) { > stop_tcg_kick_timer(); > qemu_cond_wait(cpu->halt_cond, &qemu_global_mutex); > } > > start_tcg_kick_timer(); > > qemu_wait_io

Re: [Qemu-devel] [PATCH] replay: wake up vCPU when replaying

2018-07-09 Thread Pavel Dovgalyuk
There are some situations when this patch still doesn't help. I think this happens due to the race condition in qemu_tcg_rr_wait_io_event static void qemu_tcg_rr_wait_io_event(CPUState *cpu) { while (all_cpu_threads_idle()) { stop_tcg_kick_timer(); qemu_cond_wait(cpu->halt_cond