Re: [Qemu-devel] [PATCH] qom: enforce readonly nature of link's check callback

2017-07-06 Thread Fam Zheng
On Thu, 07/06 16:50, no-re...@patchew.org wrote: > Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 > fatal: Cannot update paths and switch to branch 'test' at the same time. > Did you intend to checkout > 'origin/patchew/1498734863-164338-1-git-send-email-imamm...@redhat.com' which > can not be

Re: [Qemu-devel] [PATCH] qom: enforce readonly nature of link's check callback

2017-07-06 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] qom: enforce readonly nature of link's check callback Message-id: 1498734863-164338-1-git-send-email-imamm...@redhat.com Type: series === TEST SCRIPT BEGIN === #!/bin/b

Re: [Qemu-devel] [PATCH] qom: enforce readonly nature of link's check callback

2017-07-06 Thread Fam Zheng
On Thu, 07/06 00:16, no-re...@patchew.org wrote: > /var/tmp/patchew-tester-tmp-s55a7o8g/src/hw/virtio/virtio-crypto.c: In > function ‘virtio_crypto_instance_init’: > /var/tmp/patchew-tester-tmp-s55a7o8g/src/hw/virtio/virtio-crypto.c:918:30: > error: passing argument 5 of ‘object_property_add_link

Re: [Qemu-devel] [PATCH] qom: enforce readonly nature of link's check callback

2017-06-30 Thread Fam Zheng
On Fri, 06/30 12:41, Paolo Bonzini wrote: > > > On 29/06/2017 13:14, Igor Mammedov wrote: > > link's check callback is supposed to verify/permit setting it, > > however currently nothing restricts it from misusing it > > and modifying target object from within. > > Make sure that readonly semanti

Re: [Qemu-devel] [PATCH] qom: enforce readonly nature of link's check callback

2017-06-30 Thread Paolo Bonzini
On 29/06/2017 13:14, Igor Mammedov wrote: > link's check callback is supposed to verify/permit setting it, > however currently nothing restricts it from misusing it > and modifying target object from within. > Make sure that readonly semantics are checked by compiler > to prevent callback's misus

Re: [Qemu-devel] [PATCH] qom: enforce readonly nature of link's check callback

2017-06-29 Thread Igor Mammedov
On Thu, 29 Jun 2017 15:45:04 +0200 Paolo Bonzini wrote: > On 29/06/2017 13:14, Igor Mammedov wrote: > > link's check callback is supposed to verify/permit setting it, > > however currently nothing restricts it from misusing it > > and modifying target object from within. > > Make sure that readon

Re: [Qemu-devel] [PATCH] qom: enforce readonly nature of link's check callback

2017-06-29 Thread Paolo Bonzini
On 29/06/2017 13:14, Igor Mammedov wrote: > link's check callback is supposed to verify/permit setting it, > however currently nothing restricts it from misusing it > and modifying target object from within. > Make sure that readonly semantics are checked by compiler > to prevent callback's misuse.