Re: [Qemu-devel] [PATCH] qemu-iotests: Test streaming with missing job ID

2017-05-17 Thread Jeff Cody
On Mon, May 15, 2017 at 02:39:40PM +0200, Kevin Wolf wrote: > This adds a small test for the image streaming error path for failing > block_job_create(), which would have found the null pointer dereference > in commit a170a91f. > > Signed-off-by: Kevin Wolf > --- Reviewed-by: Jeff Cody > tes

Re: [Qemu-devel] [PATCH] qemu-iotests: Test streaming with missing job ID

2017-05-17 Thread Kashyap Chamarthy
On Mon, May 15, 2017 at 02:39:40PM +0200, Kevin Wolf wrote: > This adds a small test for the image streaming error path for failing > block_job_create(), which would have found the null pointer dereference > in commit a170a91f. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/030 | 4

Re: [Qemu-devel] [PATCH] qemu-iotests: Test streaming with missing job ID

2017-05-15 Thread Alberto Garcia
On Mon 15 May 2017 03:05:00 PM CEST, Kevin Wolf wrote: >> Mmm... but does that trigger the bug? >> >> The bug happens if the user tries to create a stream job on a BDS that: >> >> a) exists >> b) is not the active node (i.e. needs reopening in read-write mode) >> c) its node name is not valid for

Re: [Qemu-devel] [PATCH] qemu-iotests: Test streaming with missing job ID

2017-05-15 Thread Kevin Wolf
Am 15.05.2017 um 14:46 hat Alberto Garcia geschrieben: > On Mon 15 May 2017 02:39:40 PM CEST, Kevin Wolf wrote: > > This adds a small test for the image streaming error path for failing > > block_job_create(), which would have found the null pointer dereference > > in commit a170a91f. > > > > Signe

Re: [Qemu-devel] [PATCH] qemu-iotests: Test streaming with missing job ID

2017-05-15 Thread Alberto Garcia
On Mon 15 May 2017 02:39:40 PM CEST, Kevin Wolf wrote: > This adds a small test for the image streaming error path for failing > block_job_create(), which would have found the null pointer dereference > in commit a170a91f. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/030 | 4