Re: [Qemu-devel] [PATCH] qemu-img: Print error if check failed

2014-10-23 Thread Max Reitz
On 2014-10-23 at 15:29, Max Reitz wrote: Currently, if bdrv_check() fails either by returning -errno or having check_errors set, qemu-img check just exits with 1 after having told the user that there were no errors on the image. This is bad. Instead of printing the check result if there were int

Re: [Qemu-devel] [PATCH] qemu-img: Print error if check failed

2014-10-23 Thread Markus Armbruster
Max Reitz writes: > Currently, if bdrv_check() fails either by returning -errno or having > check_errors set, qemu-img check just exits with 1 after having told the > user that there were no errors on the image. This is bad. > > Instead of printing the check result if there were internal errors w

Re: [Qemu-devel] [PATCH] qemu-img: Print error if check failed

2014-10-23 Thread Eric Blake
On 10/23/2014 07:59 AM, Max Reitz wrote: > On 2014-10-23 at 15:51, Eric Blake wrote: >> On 10/23/2014 07:29 AM, Max Reitz wrote: >>> Currently, if bdrv_check() fails either by returning -errno or having >>> check_errors set, qemu-img check just exits with 1 after having told the >>> user that there

Re: [Qemu-devel] [PATCH] qemu-img: Print error if check failed

2014-10-23 Thread Max Reitz
On 2014-10-23 at 15:51, Eric Blake wrote: On 10/23/2014 07:29 AM, Max Reitz wrote: Currently, if bdrv_check() fails either by returning -errno or having check_errors set, qemu-img check just exits with 1 after having told the user that there were no errors on the image. This is bad. Instead of

Re: [Qemu-devel] [PATCH] qemu-img: Print error if check failed

2014-10-23 Thread Eric Blake
On 10/23/2014 07:29 AM, Max Reitz wrote: > Currently, if bdrv_check() fails either by returning -errno or having > check_errors set, qemu-img check just exits with 1 after having told the > user that there were no errors on the image. This is bad. > > Instead of printing the check result if there