Re: [Qemu-devel] [PATCH] qdev-monitor.c: Add device id generation

2015-08-25 Thread Programmingkid
On Aug 25, 2015, at 2:30 PM, Markus Armbruster wrote: > Programmingkid writes: > >> On Aug 25, 2015, at 11:33 AM, Peter Maydell wrote: >> >>> On 25 August 2015 at 16:25, Programmingkid >>> wrote: On Aug 25, 2015, at 8:42 AM, Markus Armbruster wrote: > Eric Blake writes: >

Re: [Qemu-devel] [PATCH] qdev-monitor.c: Add device id generation

2015-08-25 Thread Markus Armbruster
Programmingkid writes: > On Aug 25, 2015, at 11:33 AM, Peter Maydell wrote: > >> On 25 August 2015 at 16:25, Programmingkid wrote: >>> On Aug 25, 2015, at 8:42 AM, Markus Armbruster wrote: Eric Blake writes: > On 08/24/2015 12:53 PM, Programmingkid wrote: >> +/* USB's max num

Re: [Qemu-devel] [PATCH] qdev-monitor.c: Add device id generation

2015-08-25 Thread Programmingkid
On Aug 25, 2015, at 11:33 AM, Peter Maydell wrote: > On 25 August 2015 at 16:25, Programmingkid wrote: >> On Aug 25, 2015, at 8:42 AM, Markus Armbruster wrote: >>> Eric Blake writes: >>> On 08/24/2015 12:53 PM, Programmingkid wrote: > +/* USB's max number of devices is 127. This numbe

Re: [Qemu-devel] [PATCH] qdev-monitor.c: Add device id generation

2015-08-25 Thread Peter Maydell
On 25 August 2015 at 16:25, Programmingkid wrote: > On Aug 25, 2015, at 8:42 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> On 08/24/2015 12:53 PM, Programmingkid wrote: +/* USB's max number of devices is 127. This number is 3 digits long. */ +#define MAX_NUM_DIGITS_FOR_USB_I

Re: [Qemu-devel] [PATCH] qdev-monitor.c: Add device id generation

2015-08-25 Thread Programmingkid
On Aug 25, 2015, at 8:42 AM, Markus Armbruster wrote: > My other reply is about design issues. This one is about the actual > code. Until we get rough consensus on the former, the latter doesn't > really matter, but here goes anyway. > > Eric Blake writes: > >> On 08/24/2015 12:53 PM, Progra

Re: [Qemu-devel] [PATCH] qdev-monitor.c: Add device id generation

2015-08-25 Thread Programmingkid
On Aug 24, 2015, at 6:21 PM, Eric Blake wrote: > On 08/24/2015 12:53 PM, Programmingkid wrote: >> Add device ID generation to each device if an ID isn't given. >> >> Signed-off-by: John Arbuckle >> >> --- > >> dev->id = id; >> +} else { /* create an id for a device if none is prov

Re: [Qemu-devel] [PATCH] qdev-monitor.c: Add device id generation

2015-08-25 Thread Markus Armbruster
My other reply is about design issues. This one is about the actual code. Until we get rough consensus on the former, the latter doesn't really matter, but here goes anyway. Eric Blake writes: > On 08/24/2015 12:53 PM, Programmingkid wrote: >> Add device ID generation to each device if an ID i

Re: [Qemu-devel] [PATCH] qdev-monitor.c: Add device id generation

2015-08-24 Thread Eric Blake
On 08/24/2015 12:53 PM, Programmingkid wrote: > Add device ID generation to each device if an ID isn't given. > > Signed-off-by: John Arbuckle > > --- > dev->id = id; > +} else { /* create an id for a device if none is provided */ > +static int device_id_count; > + > +