Re: [Qemu-devel] [PATCH] qdev: Skip non-existing properties when setting globals

2014-06-07 Thread Peter Maydell
On 7 June 2014 02:09, Eduardo Habkost wrote: > On Sat, Jun 07, 2014 at 12:45:26AM +0100, Peter Maydell wrote: >> I'm with Eduardo on this one -- if the user passes us a bad >> command line we should diagnose it helpfully and exit with >> a failure code; abort() is for programming errors. (If nothi

Re: [Qemu-devel] [PATCH] qdev: Skip non-existing properties when setting globals

2014-06-06 Thread Eduardo Habkost
On Sat, Jun 07, 2014 at 12:45:26AM +0100, Peter Maydell wrote: > On 7 June 2014 00:22, Igor Mammedov wrote: > > Eduardo Habkost wrote: > >> On Fri, Jun 06, 2014 at 11:38:58PM +0200, Igor Mammedov wrote: > >> > Eduardo Habkost wrote: > >> > > $ ./install/bin/qemu-system-x86_64 -global cpu.fooba

Re: [Qemu-devel] [PATCH] qdev: Skip non-existing properties when setting globals

2014-06-06 Thread Peter Maydell
On 7 June 2014 00:22, Igor Mammedov wrote: > Eduardo Habkost wrote: >> On Fri, Jun 06, 2014 at 11:38:58PM +0200, Igor Mammedov wrote: >> > Eduardo Habkost wrote: >> > > $ ./install/bin/qemu-system-x86_64 -global cpu.foobar=5 >> > > qemu-system-x86_64: Property '.foobar' not found >> > > Ab

Re: [Qemu-devel] [PATCH] qdev: Skip non-existing properties when setting globals

2014-06-06 Thread Igor Mammedov
On Fri, 6 Jun 2014 19:21:36 -0300 Eduardo Habkost wrote: > On Fri, Jun 06, 2014 at 11:38:58PM +0200, Igor Mammedov wrote: > > On Fri, 6 Jun 2014 17:14:29 -0300 > > Eduardo Habkost wrote: > > > > > This avoids QEMU from aborting on cases like this: > > > > > > $ ./install/bin/qemu-system-x86_

Re: [Qemu-devel] [PATCH] qdev: Skip non-existing properties when setting globals

2014-06-06 Thread Eduardo Habkost
On Fri, Jun 06, 2014 at 11:38:58PM +0200, Igor Mammedov wrote: > On Fri, 6 Jun 2014 17:14:29 -0300 > Eduardo Habkost wrote: > > > This avoids QEMU from aborting on cases like this: > > > > $ ./install/bin/qemu-system-x86_64 -global cpu.foobar=5 > > qemu-system-x86_64: Property '.foobar' not

Re: [Qemu-devel] [PATCH] qdev: Skip non-existing properties when setting globals

2014-06-06 Thread Igor Mammedov
On Fri, 6 Jun 2014 17:14:29 -0300 Eduardo Habkost wrote: > This avoids QEMU from aborting on cases like this: > > $ ./install/bin/qemu-system-x86_64 -global cpu.foobar=5 > qemu-system-x86_64: Property '.foobar' not found > Aborted (core dumped) That is expected behavior. > > The code set

Re: [Qemu-devel] [PATCH] qdev: Skip non-existing properties when setting globals

2014-06-06 Thread Don Slutz
On 06/06/14 16:14, Eduardo Habkost wrote: This avoids QEMU from aborting on cases like this: $ ./install/bin/qemu-system-x86_64 -global cpu.foobar=5 qemu-system-x86_64: Property '.foobar' not found Aborted (core dumped) The code sets dev->not_used if the property is not found as an eff