Re: [Qemu-devel] [PATCH] qapi: Reintroduce CommandDisabled error class

2019-08-30 Thread Markus Armbruster
Michal Privoznik writes: > On 8/29/19 3:12 PM, Eric Blake wrote: >> On 8/29/19 8:04 AM, Michal Privoznik wrote: >> > A bit of background: up until very recently libvirt used qemu-ga > in all or nothing way. It didn't care why a qemu-ga command > failed. But very recently a new API was

Re: [Qemu-devel] [PATCH] qapi: Reintroduce CommandDisabled error class

2019-08-30 Thread Michal Privoznik
On 8/30/19 1:52 PM, Markus Armbruster wrote: Michal Privoznik writes: On 8/29/19 3:12 PM, Eric Blake wrote: On 8/29/19 8:04 AM, Michal Privoznik wrote: A bit of background: up until very recently libvirt used qemu-ga in all or nothing way. It didn't care why a qemu-ga command failed. But ve

Re: [Qemu-devel] [PATCH] qapi: Reintroduce CommandDisabled error class

2019-08-29 Thread Michal Privoznik
On 8/29/19 3:12 PM, Eric Blake wrote: On 8/29/19 8:04 AM, Michal Privoznik wrote: A bit of background: up until very recently libvirt used qemu-ga in all or nothing way. It didn't care why a qemu-ga command failed. But very recently a new API was introduced which implements 'best effort' approa

Re: [Qemu-devel] [PATCH] qapi: Reintroduce CommandDisabled error class

2019-08-29 Thread Eric Blake
On 8/29/19 8:04 AM, Michal Privoznik wrote: >>> A bit of background: up until very recently libvirt used qemu-ga >>> in all or nothing way. It didn't care why a qemu-ga command >>> failed. But very recently a new API was introduced which >>> implements 'best effort' approach (in some cases) and th

Re: [Qemu-devel] [PATCH] qapi: Reintroduce CommandDisabled error class

2019-08-29 Thread Michal Privoznik
On 8/29/19 2:10 PM, Markus Armbruster wrote: > Michal Privoznik writes: > >> If there was a disabled command, then qemu-ga used to report >> CommandDisabled error class (among with human readable >> description). This changed in v1.2.0-rc0~28^2~16 in favor of >> GenericError class. > > Really?

Re: [Qemu-devel] [PATCH] qapi: Reintroduce CommandDisabled error class

2019-08-29 Thread Markus Armbruster
Michal Privoznik writes: > If there was a disabled command, then qemu-ga used to report > CommandDisabled error class (among with human readable > description). This changed in v1.2.0-rc0~28^2~16 in favor of > GenericError class. Really? I believe it was slightly earlier in the same series: 93