Re: [Qemu-devel] [PATCH] pci: Fix unreasonable return value check

2017-06-01 Thread Marcel Apfelbaum
On 01/06/2017 5:51, Mao Zhongyi wrote: Hi, Markus On 05/31/2017 07:07 PM, Markus Armbruster wrote: This is cleanup, not a bug fix, so: pci: Clean up error checking in pci_add_capability() Mao Zhongyi writes: The return value of pci_add_capability2() is only 2 cases, positive on succe

Re: [Qemu-devel] [PATCH] pci: Fix unreasonable return value check

2017-05-31 Thread Mao Zhongyi
Hi, Markus On 05/31/2017 07:07 PM, Markus Armbruster wrote: This is cleanup, not a bug fix, so: pci: Clean up error checking in pci_add_capability() Mao Zhongyi writes: The return value of pci_add_capability2() is only 2 cases, positive on success, nagetive on failure and set error mess

Re: [Qemu-devel] [PATCH] pci: Fix unreasonable return value check

2017-05-31 Thread Markus Armbruster
This is cleanup, not a bug fix, so: pci: Clean up error checking in pci_add_capability() Mao Zhongyi writes: > The return value of pci_add_capability2() is only 2 cases, positive > on success, nagetive on failure and set error message to Error. In negative > other worlds, If Error is fill