Re: [Qemu-devel] [PATCH] misc: Remove unused Error variables

2017-08-30 Thread Stefan Hajnoczi
On Tue, Aug 29, 2017 at 03:08:36PM +0300, Alberto Garcia wrote: > There's a few cases which we're passing an Error pointer to a function > only to discard it immediately afterwards without checking it. In > these cases we can simply remove the variable and pass NULL instead. > > Signed-off-by: Alb

Re: [Qemu-devel] [PATCH] misc: Remove unused Error variables

2017-08-29 Thread Alberto Garcia
On Tue 29 Aug 2017 04:40:35 PM CEST, Eric Blake wrote: >> There's a few cases which we're passing an Error pointer to a Hmmm... this was "few cases in which", but it seems that I accidentally removed the "in". Not very important, but whoever commits this feel free to fix the message. Berto

Re: [Qemu-devel] [PATCH] misc: Remove unused Error variables

2017-08-29 Thread Eric Blake
On 08/29/2017 07:08 AM, Alberto Garcia wrote: > There's a few cases which we're passing an Error pointer to a function > only to discard it immediately afterwards without checking it. In > these cases we can simply remove the variable and pass NULL instead. Could also go in via qemu-trivial or Mar

Re: [Qemu-devel] [PATCH] misc: Remove unused Error variables

2017-08-29 Thread Alberto Garcia
On Tue 29 Aug 2017 02:31:35 PM CEST, Philippe Mathieu-Daudé wrote: >> There's a few cases which we're passing an Error pointer to a function >> only to discard it immediately afterwards without checking it. In >> these cases we can simply remove the variable and pass NULL instead. > > How did you

Re: [Qemu-devel] [PATCH] misc: Remove unused Error variables

2017-08-29 Thread Philippe Mathieu-Daudé
Hi Alberto, On 08/29/2017 09:08 AM, Alberto Garcia wrote: There's a few cases which we're passing an Error pointer to a function only to discard it immediately afterwards without checking it. In these cases we can simply remove the variable and pass NULL instead. How did you notice? Signed-