Re: [Qemu-devel] [PATCH] migration: introduce decompress-error-check

2018-05-02 Thread Peter Xu
On Wed, May 02, 2018 at 03:57:13PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Fri, Apr 27, 2018 at 06:40:09PM +0800, Xiao Guangrong wrote: > > > > > > > > > On 04/27/2018 05:31 PM, Peter Xu wrote: > > > > On Fri, Apr 27, 2018 at 11:15:37AM +0800, Xiao Guan

Re: [Qemu-devel] [PATCH] migration: introduce decompress-error-check

2018-05-02 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Fri, Apr 27, 2018 at 06:40:09PM +0800, Xiao Guangrong wrote: > > > > > > On 04/27/2018 05:31 PM, Peter Xu wrote: > > > On Fri, Apr 27, 2018 at 11:15:37AM +0800, Xiao Guangrong wrote: > > > > > > > > > > > > On 04/26/2018 10:01 PM, Eric Blake wrote: > >

Re: [Qemu-devel] [PATCH] migration: introduce decompress-error-check

2018-05-01 Thread Peter Xu
On Fri, Apr 27, 2018 at 06:40:09PM +0800, Xiao Guangrong wrote: > > > On 04/27/2018 05:31 PM, Peter Xu wrote: > > On Fri, Apr 27, 2018 at 11:15:37AM +0800, Xiao Guangrong wrote: > > > > > > > > > On 04/26/2018 10:01 PM, Eric Blake wrote: > > > > On 04/26/2018 04:15 AM, guangrong.x...@gmail.com

Re: [Qemu-devel] [PATCH] migration: introduce decompress-error-check

2018-04-27 Thread Xiao Guangrong
On 04/27/2018 07:29 PM, Dr. David Alan Gilbert wrote: Yes, can not agree with you more. :) The challenge is how to put something into the stream without breaking an old version of QEMU that's receiving the stream. Er, i did not think this case :(. The new parameter as this patch did is

Re: [Qemu-devel] [PATCH] migration: introduce decompress-error-check

2018-04-27 Thread Dr. David Alan Gilbert
* Xiao Guangrong (guangrong.x...@gmail.com) wrote: > > > On 04/26/2018 10:01 PM, Eric Blake wrote: > > On 04/26/2018 04:15 AM, guangrong.x...@gmail.com wrote: > > > From: Xiao Guangrong > > > > > > QEMU 2.13 enables strict check for compression & decompression to > > > make the migration more r

Re: [Qemu-devel] [PATCH] migration: introduce decompress-error-check

2018-04-27 Thread Xiao Guangrong
On 04/27/2018 05:31 PM, Peter Xu wrote: On Fri, Apr 27, 2018 at 11:15:37AM +0800, Xiao Guangrong wrote: On 04/26/2018 10:01 PM, Eric Blake wrote: On 04/26/2018 04:15 AM, guangrong.x...@gmail.com wrote: From: Xiao Guangrong QEMU 2.13 enables strict check for compression & decompression to

Re: [Qemu-devel] [PATCH] migration: introduce decompress-error-check

2018-04-27 Thread Peter Xu
On Fri, Apr 27, 2018 at 11:15:37AM +0800, Xiao Guangrong wrote: > > > On 04/26/2018 10:01 PM, Eric Blake wrote: > > On 04/26/2018 04:15 AM, guangrong.x...@gmail.com wrote: > > > From: Xiao Guangrong > > > > > > QEMU 2.13 enables strict check for compression & decompression to > > > make the mig

Re: [Qemu-devel] [PATCH] migration: introduce decompress-error-check

2018-04-26 Thread Xiao Guangrong
On 04/26/2018 10:01 PM, Eric Blake wrote: On 04/26/2018 04:15 AM, guangrong.x...@gmail.com wrote: From: Xiao Guangrong QEMU 2.13 enables strict check for compression & decompression to make the migration more robuster, that depends on the source to fix s/robuster/robust/ Will fix, thank

Re: [Qemu-devel] [PATCH] migration: introduce decompress-error-check

2018-04-26 Thread Eric Blake
On 04/26/2018 04:15 AM, guangrong.x...@gmail.com wrote: > From: Xiao Guangrong > > QEMU 2.13 enables strict check for compression & decompression to > make the migration more robuster, that depends on the source to fix s/robuster/robust/ > the internal design which triggers the unexpected error

Re: [Qemu-devel] [PATCH] migration: introduce decompress-error-check

2018-04-26 Thread Xiao Guangrong
On 04/26/2018 05:34 PM, Dr. David Alan Gilbert wrote: * guangrong.x...@gmail.com (guangrong.x...@gmail.com) wrote: From: Xiao Guangrong QEMU 2.13 enables strict check for compression & decompression to make the migration more robuster, that depends on the source to fix the internal design wh

Re: [Qemu-devel] [PATCH] migration: introduce decompress-error-check

2018-04-26 Thread Dr. David Alan Gilbert
* guangrong.x...@gmail.com (guangrong.x...@gmail.com) wrote: > From: Xiao Guangrong > > QEMU 2.13 enables strict check for compression & decompression to > make the migration more robuster, that depends on the source to fix > the internal design which triggers the unexpected error conditions Hmm

Re: [Qemu-devel] [PATCH] migration: introduce decompress-error-check

2018-04-26 Thread Xiao Guangrong
Hi Dave, On 04/26/2018 05:15 PM, guangrong.x...@gmail.com wrote: From: Xiao Guangrong QEMU 2.13 enables strict check for compression & decompression to make the migration more robuster, that depends on the source to fix the internal design which triggers the unexpected error conditions To ma