Re: [Qemu-devel] [PATCH] memory.h: Improve IOMMU related documentation

2018-04-30 Thread David Gibson
On Mon, Apr 30, 2018 at 08:28:35AM -0600, Alex Williamson wrote: > On Mon, 30 Apr 2018 14:35:20 +0100 > Peter Maydell wrote: > > > On 30 April 2018 at 14:08, Paolo Bonzini wrote: > > > On 30/04/2018 14:57, Peter Maydell wrote: > > >> On 30 April 2018 at 13:54, Paolo Bonzini wrote: > > >>> O

Re: [Qemu-devel] [PATCH] memory.h: Improve IOMMU related documentation

2018-04-30 Thread Paolo Bonzini
On 30/04/2018 15:34, Peter Maydell wrote: >> */ >> IOMMUTLBEntry (*translate)(IOMMUMemoryRegion *iommu, hwaddr addr, >> IOMMUAccessFlags flag); > A question I just thought of -- how long is the IOMMUTLBEntry I get > back guaranteed to be valid for? For ins

Re: [Qemu-devel] [PATCH] memory.h: Improve IOMMU related documentation

2018-04-30 Thread Alex Williamson
On Mon, 30 Apr 2018 14:35:20 +0100 Peter Maydell wrote: > On 30 April 2018 at 14:08, Paolo Bonzini wrote: > > On 30/04/2018 14:57, Peter Maydell wrote: > >> On 30 April 2018 at 13:54, Paolo Bonzini wrote: > >>> On 30/04/2018 14:24, Peter Maydell wrote: > -/* Set this up to provid

Re: [Qemu-devel] [PATCH] memory.h: Improve IOMMU related documentation

2018-04-30 Thread Peter Maydell
On 30 April 2018 at 14:08, Paolo Bonzini wrote: > On 30/04/2018 14:57, Peter Maydell wrote: >> On 30 April 2018 at 13:54, Paolo Bonzini wrote: >>> On 30/04/2018 14:24, Peter Maydell wrote: -/* Set this up to provide customized IOMMU replay function */ +/* Set this up to provide

Re: [Qemu-devel] [PATCH] memory.h: Improve IOMMU related documentation

2018-04-30 Thread Peter Maydell
On 30 April 2018 at 13:24, Peter Maydell wrote: > Add more detail to the documentation for memory_region_init_iommu() > and other IOMMU-related functions and data structures. > @@ -203,20 +211,58 @@ typedef struct IOMMUMemoryRegionClass { > * be the access permission of this translation ope

Re: [Qemu-devel] [PATCH] memory.h: Improve IOMMU related documentation

2018-04-30 Thread Paolo Bonzini
On 30/04/2018 14:57, Peter Maydell wrote: > On 30 April 2018 at 13:54, Paolo Bonzini wrote: >> On 30/04/2018 14:24, Peter Maydell wrote: >>> -/* Set this up to provide customized IOMMU replay function */ >>> +/* Set this up to provide customized IOMMU replay function. >>> + * Optional

Re: [Qemu-devel] [PATCH] memory.h: Improve IOMMU related documentation

2018-04-30 Thread Peter Maydell
On 30 April 2018 at 13:54, Paolo Bonzini wrote: > On 30/04/2018 14:24, Peter Maydell wrote: >> -/* Set this up to provide customized IOMMU replay function */ >> +/* Set this up to provide customized IOMMU replay function. >> + * Optional method. >> + */ >> void (*replay)(IOMMU

Re: [Qemu-devel] [PATCH] memory.h: Improve IOMMU related documentation

2018-04-30 Thread Paolo Bonzini
On 30/04/2018 14:24, Peter Maydell wrote: > -/* Set this up to provide customized IOMMU replay function */ > +/* Set this up to provide customized IOMMU replay function. > + * Optional method. > + */ > void (*replay)(IOMMUMemoryRegion *iommu, IOMMUNotifier *notifier); replay i