Re: [Qemu-devel] [PATCH] keyboard: handle ps2 typing buffer overrun

2015-06-03 Thread Michael Tokarev
Okay, while the patch has been criticised by Eric already, mostly due to the commit message and stylistic errors in the code, but what about the code changed in this patch, are the changes needed, correct? I remember a discussion on a related topic, http://thread.gmane.org/gmane.comp.emulators.qem

Re: [Qemu-devel] [PATCH] keyboard: handle ps2 typing buffer overrun

2015-05-18 Thread Eric Blake
On 05/18/2015 06:54 AM, Eric Blake wrote: > On 05/17/2015 10:00 AM, penghao...@sina.com wrote: >> Subject: [PATCH] keyboard: handle ps2 typing buffer overrun > > This line is redundant. > > Also, you have tried to send this patch more than once. Please be sure > to include a proper 'v3' or 'v4'

Re: [Qemu-devel] [PATCH] keyboard: handle ps2 typing buffer overrun

2015-05-18 Thread Eric Blake
On 05/17/2015 10:00 AM, penghao...@sina.com wrote: > Subject: [PATCH] keyboard: handle ps2 typing buffer overrun This line is redundant. Also, you have tried to send this patch more than once. Please be sure to include a proper 'v3' or 'v4' in the subject line, as appropriate. > Starting a linu