Re: [Qemu-devel] [PATCH] gdbstub: Fix buffer overflows in gdb_handle_packet()

2015-10-29 Thread Michael Tokarev
13.10.2015 10:38, Kevin Wolf wrote: > Some places in gdb_handle_packet() can get an arbitrary length (most > times directly from the client) and either didn't check it at all or > checked against the wrong value, potentially causing buffer overflows. Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH] gdbstub: Fix buffer overflows in gdb_handle_packet()

2015-10-14 Thread P J P
+-- On Wed, 14 Oct 2015, Kevin Wolf wrote --+ | > Ie host gdb(1) user would need to | > supply len/2 value to read/write 'len' bytes. | | That's just how the gdb protocol works. Binary data is transferred as a | string of hex digits, with every byte being represented by two digits. | The request

Re: [Qemu-devel] [PATCH] gdbstub: Fix buffer overflows in gdb_handle_packet()

2015-10-14 Thread Kevin Wolf
Am 14.10.2015 um 08:53 hat P J P geschrieben: > +-- On Tue, 13 Oct 2015, Kevin Wolf wrote --+ > | diff --git a/gdbstub.c b/gdbstub.c > | index d2c95b5..9c29aa0 100644 > | --- a/gdbstub.c > | +++ b/gdbstub.c > | @@ -956,6 +956,13 @@ static int gdb_handle_packet(GDBState *s, const char > *line_buf)

Re: [Qemu-devel] [PATCH] gdbstub: Fix buffer overflows in gdb_handle_packet()

2015-10-13 Thread P J P
+-- On Tue, 13 Oct 2015, Kevin Wolf wrote --+ | diff --git a/gdbstub.c b/gdbstub.c | index d2c95b5..9c29aa0 100644 | --- a/gdbstub.c | +++ b/gdbstub.c | @@ -956,6 +956,13 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf) | if (*p == ',') | p++; | len