Re: [Qemu-devel] [PATCH] fdc: fix drive property handling.

2010-03-13 Thread Aurelien Jarno
On Wed, Mar 10, 2010 at 05:30:29PM +0100, Gerd Hoffmann wrote: > Fix the floppy controller init wrappers to set the drive properties > only in case the DriveInfo pointers passed in are non NULL. This allows > to set the properties using -global. > > [ v2: fix code style issues pointed out by Aure

Re: [Qemu-devel] [PATCH] fdc: fix drive property handling.

2009-12-16 Thread Markus Armbruster
Gerd Hoffmann writes: > On 12/16/09 11:03, Markus Armbruster wrote: >> This fixes "-global isa-fdc,driveB=DRIVE-ID" for me, but problems >> remain: >> >> * -drive if=none,id=fd,file=fd.img -global isa-fdc.driveA=fd >> >>dev: isa-fdc, id "" >> dev-prop: driveA = floppy0 >>

Re: [Qemu-devel] [PATCH] fdc: fix drive property handling.

2009-12-16 Thread Gerd Hoffmann
On 12/16/09 11:03, Markus Armbruster wrote: This fixes "-global isa-fdc,driveB=DRIVE-ID" for me, but problems remain: * -drive if=none,id=fd,file=fd.img -global isa-fdc.driveA=fd dev: isa-fdc, id "" dev-prop: driveA = floppy0 dev-prop: driveB =

Re: [Qemu-devel] [PATCH] fdc: fix drive property handling.

2009-12-16 Thread Markus Armbruster
Gerd Hoffmann writes: > Fix the floppy controller init wrappers to set the drive properties > only in case the DriveInfo pointers passed in are non NULL. This allows > to set the properties using -global. > > Signed-off-by: Gerd Hoffmann This fixes "-global isa-fdc,driveB=DRIVE-ID" for me, but