Re: [Qemu-devel] [PATCH] e1000: make ICS write-only

2013-01-09 Thread Bill Paul
Of all the gin joints in all the towns in all the world, Michael S. Tsirkin had to walk into mine at 13:44:38 on Wednesday 09 January 2013 and say: > On Wed, Jan 09, 2013 at 09:30:43AM -0800, Bill Paul wrote: > > Of all the gin joints in all the towns in all the world, Michael S. > > Tsirkin > >

Re: [Qemu-devel] [PATCH] e1000: make ICS write-only

2013-01-09 Thread Michael S. Tsirkin
On Wed, Jan 09, 2013 at 02:21:50PM -0800, Bill Paul wrote: > Of all the gin joints in all the towns in all the world, Michael S. Tsirkin > had to walk into mine at 14:07:53 on Wednesday 09 January 2013 and say: > > > On Wed, Jan 09, 2013 at 01:50:39PM -0600, Anthony Liguori wrote: > > > I figured

Re: [Qemu-devel] [PATCH] e1000: make ICS write-only

2013-01-09 Thread Bill Paul
Of all the gin joints in all the towns in all the world, Michael S. Tsirkin had to walk into mine at 14:07:53 on Wednesday 09 January 2013 and say: > On Wed, Jan 09, 2013 at 01:50:39PM -0600, Anthony Liguori wrote: > > I figured this would be the case but this is where a comment in the code > > o

Re: [Qemu-devel] [PATCH] e1000: make ICS write-only

2013-01-09 Thread Bill Paul
Of all the gin joints in all the towns in all the world, Michael S. Tsirkin had to walk into mine at 02:51:00 on Wednesday 09 January 2013 and say: > Since commit b1332393cdd7d023de8f1f8aa136ee7866a18968, > qemu started updating ICS register when interrupt > is sent, with the intent to match spec

Re: [Qemu-devel] [PATCH] e1000: make ICS write-only

2013-01-09 Thread Michael S. Tsirkin
On Wed, Jan 09, 2013 at 01:50:39PM -0600, Anthony Liguori wrote: > I figured this would be the case but this is where a comment in the code > or commit message would have helped a lot in avoiding future confusion. > > Regards, > > Anthony Liguori I just sent a documentation patch, please take a

Re: [Qemu-devel] [PATCH] e1000: make ICS write-only

2013-01-09 Thread Michael S. Tsirkin
On Wed, Jan 09, 2013 at 09:30:43AM -0800, Bill Paul wrote: > Of all the gin joints in all the towns in all the world, Michael S. Tsirkin > had to walk into mine at 02:51:00 on Wednesday 09 January 2013 and say: > > > Since commit b1332393cdd7d023de8f1f8aa136ee7866a18968, > > qemu started updating

Re: [Qemu-devel] [PATCH] e1000: make ICS write-only

2013-01-09 Thread Anthony Liguori
Bill Paul writes: > Of all the gin joints in all the towns in all the world, Michael S. Tsirkin > had to walk into mine at 02:51:00 on Wednesday 09 January 2013 and say: > >> Since commit b1332393cdd7d023de8f1f8aa136ee7866a18968, >> qemu started updating ICS register when interrupt >> is sent, w

Re: [Qemu-devel] [PATCH] e1000: make ICS write-only

2013-01-09 Thread Michael S. Tsirkin
On Wed, Jan 09, 2013 at 09:30:43AM -0800, Bill Paul wrote: > Of all the gin joints in all the towns in all the world, Michael S. Tsirkin > had to walk into mine at 02:51:00 on Wednesday 09 January 2013 and say: > > > Since commit b1332393cdd7d023de8f1f8aa136ee7866a18968, > > qemu started updating

Re: [Qemu-devel] [PATCH] e1000: make ICS write-only

2013-01-09 Thread Michael S. Tsirkin
On Wed, Jan 09, 2013 at 11:28:29PM +0800, Jason Wang wrote: > On 01/09/2013 06:51 PM, Michael S. Tsirkin wrote: > > Since commit b1332393cdd7d023de8f1f8aa136ee7866a18968, > > qemu started updating ICS register when interrupt > > is sent, with the intent to match spec better > > (guests do not actua

Re: [Qemu-devel] [PATCH] e1000: make ICS write-only

2013-01-09 Thread Michael S. Tsirkin
On Wed, Jan 09, 2013 at 11:36:50PM +0800, Jason Wang wrote: > On 01/09/2013 11:34 PM, Michael S. Tsirkin wrote: > > On Wed, Jan 09, 2013 at 11:28:29PM +0800, Jason Wang wrote: > >> On 01/09/2013 06:51 PM, Michael S. Tsirkin wrote: > >>> Since commit b1332393cdd7d023de8f1f8aa136ee7866a18968, > >>> q

Re: [Qemu-devel] [PATCH] e1000: make ICS write-only

2013-01-09 Thread Jason Wang
On 01/09/2013 11:34 PM, Michael S. Tsirkin wrote: > On Wed, Jan 09, 2013 at 11:28:29PM +0800, Jason Wang wrote: >> On 01/09/2013 06:51 PM, Michael S. Tsirkin wrote: >>> Since commit b1332393cdd7d023de8f1f8aa136ee7866a18968, >>> qemu started updating ICS register when interrupt >>> is sent, with the

Re: [Qemu-devel] [PATCH] e1000: make ICS write-only

2013-01-09 Thread Jason Wang
On 01/09/2013 06:51 PM, Michael S. Tsirkin wrote: > Since commit b1332393cdd7d023de8f1f8aa136ee7866a18968, > qemu started updating ICS register when interrupt > is sent, with the intent to match spec better > (guests do not actually read this register). > However, the function set_interrupt_cause w

Re: [Qemu-devel] [PATCH] e1000: make ICS write-only

2013-01-09 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > Since commit b1332393cdd7d023de8f1f8aa136ee7866a18968, > qemu started updating ICS register when interrupt > is sent, with the intent to match spec better > (guests do not actually read this register). > However, the function set_interrupt_cause where ICS > is updat

Re: [Qemu-devel] [PATCH] e1000: make ICS write-only

2013-01-09 Thread Stefan Hajnoczi
On Wed, Jan 09, 2013 at 12:51:00PM +0200, Michael S. Tsirkin wrote: > Since commit b1332393cdd7d023de8f1f8aa136ee7866a18968, > qemu started updating ICS register when interrupt > is sent, with the intent to match spec better > (guests do not actually read this register). > However, the function set