Re: [Qemu-devel] [PATCH] dma: rc4030: limit interval timer reload value

2017-03-14 Thread Peter Maydell
On 14 March 2017 at 19:17, Cole Robinson wrote: > I'm coming to this thread from the Fedora bug for this CVE, > https://bugzilla.redhat.com/show_bug.cgi?id=1384876 FWIW this isn't a CVE issue from the point of view of upstream QEMU, because it only affects the MIPS Jazz board, which (if I'm readi

Re: [Qemu-devel] [PATCH] dma: rc4030: limit interval timer reload value

2017-03-14 Thread Cole Robinson
On 11/16/2016 12:50 AM, Hervé Poussineau wrote: > Hi, > > Le 10/11/2016 à 15:50, Paolo Bonzini a écrit : >> >> >> On 10/11/2016 06:56, Gonglei (Arei) wrote: >>> Any ideas about this fix? >> >> It seems sensible, but perhaps the field is even smaller. Let's CC >> Hervé and Aurelien as I don't have

Re: [Qemu-devel] [PATCH] dma: rc4030: limit interval timer reload value

2016-11-17 Thread Paolo Bonzini
On 16/11/2016 07:29, P J P wrote: > +-- On Wed, 16 Nov 2016, Hervé Poussineau wrote --+ > | I don't have any datasheet for this device either, so I tested with real > | programs. Those initialize itr field to either 0 or to 9, so your mask > | doesn't change anything. > | > | Tested-by: Hervé

Re: [Qemu-devel] [PATCH] dma: rc4030: limit interval timer reload value

2016-11-15 Thread Hervé Poussineau
Le 16/11/2016 à 07:29, P J P a écrit : +-- On Wed, 16 Nov 2016, Hervé Poussineau wrote --+ | I don't have any datasheet for this device either, so I tested with real | programs. Those initialize itr field to either 0 or to 9, so your mask | doesn't change anything. | | Tested-by: Hervé Poussineau

Re: [Qemu-devel] [PATCH] dma: rc4030: limit interval timer reload value

2016-11-15 Thread P J P
+-- On Wed, 16 Nov 2016, Hervé Poussineau wrote --+ | I don't have any datasheet for this device either, so I tested with real | programs. Those initialize itr field to either 0 or to 9, so your mask | doesn't change anything. | | Tested-by: Hervé Poussineau Thank you so much. To confirm, do

Re: [Qemu-devel] [PATCH] dma: rc4030: limit interval timer reload value

2016-11-15 Thread Gonglei (Arei)
> Subject: Re: [Qemu-devel] [PATCH] dma: rc4030: limit interval timer reload > value > > Hi, > > Le 10/11/2016 à 15:50, Paolo Bonzini a écrit : > > > > > > On 10/11/2016 06:56, Gonglei (Arei) wrote: > >> Any ideas about this fix? > > > >

Re: [Qemu-devel] [PATCH] dma: rc4030: limit interval timer reload value

2016-11-15 Thread Hervé Poussineau
Hi, Le 10/11/2016 à 15:50, Paolo Bonzini a écrit : On 10/11/2016 06:56, Gonglei (Arei) wrote: Any ideas about this fix? It seems sensible, but perhaps the field is even smaller. Let's CC Hervé and Aurelien as I don't have a datasheet for this device. Sorry for the delay... I don't have

Re: [Qemu-devel] [PATCH] dma: rc4030: limit interval timer reload value

2016-11-10 Thread Paolo Bonzini
On 10/11/2016 06:56, Gonglei (Arei) wrote: > Any ideas about this fix? It seems sensible, but perhaps the field is even smaller. Let's CC Hervé and Aurelien as I don't have a datasheet for this device. Also, s->itr is used here: tm_hz = 1000 / (s->itr + 1); timer_mod(s->periodic_time

Re: [Qemu-devel] [PATCH] dma: rc4030: limit interval timer reload value

2016-11-09 Thread Gonglei (Arei)
Any ideas about this fix? Regards, -Gonglei > -Original Message- > From: Qemu-devel > [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On > Behalf Of P J P > Sent: Wednesday, October 12, 2016 8:38 PM > To: Qemu Developers > Cc: Paolo Bonzini; Huawei PSIRT; Prasad J Pandit;