Re: [Qemu-devel] [PATCH] dataplane: fix shadowed return value

2014-01-23 Thread Kevin Wolf
Am 23.01.2014 um 15:38 hat Peter Maydell geschrieben: > On 15 January 2014 03:46, Stefan Hajnoczi wrote: > > On Mon, Jan 13, 2014 at 06:47:39PM +0800, Stefan Hajnoczi wrote: > >> Propagate the error return value from get_indirect(). > >> > >> Signed-off-by: Stefan Hajnoczi > >> --- > >> hw/virti

Re: [Qemu-devel] [PATCH] dataplane: fix shadowed return value

2014-01-23 Thread Peter Maydell
On 15 January 2014 03:46, Stefan Hajnoczi wrote: > On Mon, Jan 13, 2014 at 06:47:39PM +0800, Stefan Hajnoczi wrote: >> Propagate the error return value from get_indirect(). >> >> Signed-off-by: Stefan Hajnoczi >> --- >> hw/virtio/dataplane/vring.c | 2 +- >> 1 file changed, 1 insertion(+), 1 del

Re: [Qemu-devel] [PATCH] dataplane: fix shadowed return value

2014-01-14 Thread Stefan Hajnoczi
On Mon, Jan 13, 2014 at 06:47:39PM +0800, Stefan Hajnoczi wrote: > Propagate the error return value from get_indirect(). > > Signed-off-by: Stefan Hajnoczi > --- > hw/virtio/dataplane/vring.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Fixed commit description as suggested by Markus

Re: [Qemu-devel] [PATCH] dataplane: fix shadowed return value

2014-01-14 Thread Peter Maydell
On 13 January 2014 10:47, Stefan Hajnoczi wrote: > Propagate the error return value from get_indirect(). > > Signed-off-by: Stefan Hajnoczi Reviewed-by: Peter Maydell This fixes the compilation error (see also bug 1268596). thanks -- PMM

Re: [Qemu-devel] [PATCH] dataplane: fix shadowed return value

2014-01-14 Thread Markus Armbruster
Stefan Hajnoczi writes: > Propagate the error return value from get_indirect(). > > Signed-off-by: Stefan Hajnoczi > --- > hw/virtio/dataplane/vring.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/virtio/dataplane/vring.c b/hw/virtio/dataplane/vring.c > index 250d4