Re: [Qemu-devel] [PATCH] cipher: fix leak on initialization error

2016-11-09 Thread Marc-André Lureau
Hi - Original Message - > On Wed, Nov 09, 2016 at 02:18:15PM +0400, Marc-André Lureau wrote: > > If ctx->blocksize != XTS_BLOCK_SIZE, ctx will be leaked. > > Assign ctx earler, and call qcrypto_cipher_free() on error. > > > > Spotted thanks to ASAN. > > > > Signed-off-by: Marc-André Lure

Re: [Qemu-devel] [PATCH] cipher: fix leak on initialization error

2016-11-09 Thread Daniel P. Berrange
On Wed, Nov 09, 2016 at 02:18:15PM +0400, Marc-André Lureau wrote: > If ctx->blocksize != XTS_BLOCK_SIZE, ctx will be leaked. > Assign ctx earler, and call qcrypto_cipher_free() on error. > > Spotted thanks to ASAN. > > Signed-off-by: Marc-André Lureau > --- > crypto/cipher-nettle.c | 15 ++