On Thu, 09/07 16:42, Fam Zheng wrote:
> Signed-off-by: Fam Zheng
I will include this in a coming pull request. Thanks.
Fam
On Thu, Sep 07, 2017 at 07:37:42PM +0800, Fam Zheng wrote:
> On Thu, 09/07 10:37, Dr. David Alan Gilbert wrote:
> > * Fam Zheng (f...@redhat.com) wrote:
> > > Signed-off-by: Fam Zheng
> >
> > OK, I've not actually got a preference as to whether it's
> > per-object or not - I don't really see any
Fam Zheng wrote:
> Signed-off-by: Fam Zheng
Reviewed-by: Juan Quintela
> ---
> configure | 2 +-
> migration/Makefile.objs | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index fb7e34a901..470b8a085b 100755
> --- a/configure
> +
* Fam Zheng (f...@redhat.com) wrote:
> On Thu, 09/07 10:37, Dr. David Alan Gilbert wrote:
> > * Fam Zheng (f...@redhat.com) wrote:
> > > Signed-off-by: Fam Zheng
> >
> > OK, I've not actually got a preference as to whether it's
> > per-object or not - I don't really see any advantage.
>
> Thanks
On Thu, 09/07 10:37, Dr. David Alan Gilbert wrote:
> * Fam Zheng (f...@redhat.com) wrote:
> > Signed-off-by: Fam Zheng
>
> OK, I've not actually got a preference as to whether it's
> per-object or not - I don't really see any advantage.
Thanks for the review. You're right this probably doesn't
On Thu, Sep 07, 2017 at 04:42:30PM +0800, Fam Zheng wrote:
> Signed-off-by: Fam Zheng
Reviewed-by: Peter Xu
> ---
> configure | 2 +-
> migration/Makefile.objs | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index fb7e34a901..470
* Fam Zheng (f...@redhat.com) wrote:
> Signed-off-by: Fam Zheng
OK, I've not actually got a preference as to whether it's
per-object or not - I don't really see any advantage.
But since it doesn't look like it'll break it;
Reviewed-by: Dr. David Alan Gilbert
> ---
> configure |