On 08/28/2014 06:31 AM, Stefan Hajnoczi wrote:
> On Wed, Aug 27, 2014 at 07:33:13AM -0600, Eric Blake wrote:
>> buf-size has the same bug a few lines later; might as well fix both at once.
>
> Hmm...which git tree are you looking at?
Serves me right for going off of a 'git grep' rather than actua
On Wed, Aug 27, 2014 at 07:33:13AM -0600, Eric Blake wrote:
> buf-size has the same bug a few lines later; might as well fix both at once.
Hmm...which git tree are you looking at?
I don't see any error paths for buf_size:
http://git.qemu-project.org/?p=qemu.git;a=blob;f=blockdev.c;h=6a204c662d4b6
On Wed, Aug 27, 2014 at 07:33:13AM -0600, Eric Blake wrote:
> But what you have is a strict improvement, so depending on whether you
> do a v2 to fix buf-size, vs. do a followup patch, you could add:
Thanks, I will send a follow-up.
Stefan
pgp_ZOFFNNMnE.pgp
Description: PGP signature
On Wed, Aug 27, 2014 at 02:29:59PM +0100, Stefan Hajnoczi wrote:
> Name the 'granularity' parameter and give its expected value range.
> Previously the device name was mistakingly reported as the parameter
> name.
>
> Note that the error class is unchanged from ERROR_CLASS_GENERIC_ERROR.
>
> Repo
The Wednesday 27 Aug 2014 à 14:29:59 (+0100), Stefan Hajnoczi wrote :
> Name the 'granularity' parameter and give its expected value range.
> Previously the device name was mistakingly reported as the parameter
> name.
>
> Note that the error class is unchanged from ERROR_CLASS_GENERIC_ERROR.
>
>
On 08/27/2014 07:29 AM, Stefan Hajnoczi wrote:
> Name the 'granularity' parameter and give its expected value range.
> Previously the device name was mistakingly reported as the parameter
s/mistakingly/mistakenly/
> name.
>
> Note that the error class is unchanged from ERROR_CLASS_GENERIC_ERROR.
