Re: [Qemu-devel] [PATCH] bitmap: assert that start and nr are non negative

2017-01-20 Thread Paolo Bonzini
On 19/01/2017 17:43, Peter Lieven wrote: > commit e1123a3b introduced a data corruption regression > in the iscsi driver because it passed -1 as nr to bitmap_set > and bitmap_clear. Add an assertion to catch such flaws earlier. > > Suggested-by: Fam Zheng > Signed-off-by: Peter Lieven > --- >

Re: [Qemu-devel] [PATCH] bitmap: assert that start and nr are non negative

2017-01-19 Thread Fam Zheng
On Thu, 01/19 17:43, Peter Lieven wrote: > commit e1123a3b introduced a data corruption regression > in the iscsi driver because it passed -1 as nr to bitmap_set > and bitmap_clear. Add an assertion to catch such flaws earlier. > > Suggested-by: Fam Zheng > Signed-off-by: Peter Lieven > --- > u