Re: [Qemu-devel] [PATCH] ati-vga: fix tracing

2019-03-13 Thread Stefan Hajnoczi
On Tue, Mar 12, 2019 at 02:42:50PM +0100, Philippe Mathieu-Daudé wrote: > Cc'ing Stefan This is fine. Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [Qemu-devel] [PATCH] ati-vga: fix tracing

2019-03-12 Thread Philippe Mathieu-Daudé
Cc'ing Stefan On 3/12/19 10:56 AM, Daniel P. Berrangé wrote: > On Tue, Mar 12, 2019 at 09:11:43AM +0100, Gerd Hoffmann wrote: >> HWADDR_PRIx can't be used in tracing, use PRIx64 instead. >> >> Signed-off-by: Gerd Hoffmann >> --- >> hw/display/trace-events | 4 ++-- >> 1 file changed, 2 insertion

Re: [Qemu-devel] [PATCH] ati-vga: fix tracing

2019-03-12 Thread Daniel P . Berrangé
On Tue, Mar 12, 2019 at 09:11:43AM +0100, Gerd Hoffmann wrote: > HWADDR_PRIx can't be used in tracing, use PRIx64 instead. > > Signed-off-by: Gerd Hoffmann > --- > hw/display/trace-events | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/display/trace-events b/hw/d

Re: [Qemu-devel] [PATCH] ati-vga: fix tracing

2019-03-12 Thread Markus Armbruster
Gerd Hoffmann writes: > HWADDR_PRIx can't be used in tracing, use PRIx64 instead. > > Signed-off-by: Gerd Hoffmann > --- > hw/display/trace-events | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/display/trace-events b/hw/display/trace-events > index 80993cc4d913.