Re: [Qemu-devel] [PATCH] Purge uses of banned g_assert_FOO()

2018-06-11 Thread Daniel P . Berrangé
On Mon, Jun 11, 2018 at 08:06:49AM +0200, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > > > On 06/08/2018 02:12 PM, Daniel P. Berrangé wrote: > >> On Fri, Jun 08, 2018 at 07:02:31PM +0200, Markus Armbruster wrote: > >>> We banned use of certain g_assert_FOO() functions outside tests

Re: [Qemu-devel] [PATCH] Purge uses of banned g_assert_FOO()

2018-06-10 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 06/08/2018 02:12 PM, Daniel P. Berrangé wrote: >> On Fri, Jun 08, 2018 at 07:02:31PM +0200, Markus Armbruster wrote: >>> We banned use of certain g_assert_FOO() functions outside tests, and >>> made checkpatch.pl flag them (commit 6e9389563e5). We neglected to

Re: [Qemu-devel] [PATCH] Purge uses of banned g_assert_FOO()

2018-06-08 Thread John Snow
On 06/08/2018 01:02 PM, Markus Armbruster wrote: > We banned use of certain g_assert_FOO() functions outside tests, and > made checkpatch.pl flag them (commit 6e9389563e5). We neglected to > purge existing uses. Do that now. > > Signed-off-by: Markus Armbruster I've apparently got a real kn

Re: [Qemu-devel] [PATCH] Purge uses of banned g_assert_FOO()

2018-06-08 Thread Philippe Mathieu-Daudé
On 06/08/2018 02:12 PM, Daniel P. Berrangé wrote: > On Fri, Jun 08, 2018 at 07:02:31PM +0200, Markus Armbruster wrote: >> We banned use of certain g_assert_FOO() functions outside tests, and >> made checkpatch.pl flag them (commit 6e9389563e5). We neglected to >> purge existing uses. Do that now.

Re: [Qemu-devel] [PATCH] Purge uses of banned g_assert_FOO()

2018-06-08 Thread Eric Blake
On 06/08/2018 12:02 PM, Markus Armbruster wrote: We banned use of certain g_assert_FOO() functions outside tests, and made checkpatch.pl flag them (commit 6e9389563e5). We neglected to purge existing uses. Do that now. Signed-off-by: Markus Armbruster --- Reviewed-by: Eric Blake -- Eric B

Re: [Qemu-devel] [PATCH] Purge uses of banned g_assert_FOO()

2018-06-08 Thread Daniel P . Berrangé
On Fri, Jun 08, 2018 at 07:02:31PM +0200, Markus Armbruster wrote: > We banned use of certain g_assert_FOO() functions outside tests, and > made checkpatch.pl flag them (commit 6e9389563e5). We neglected to > purge existing uses. Do that now. > > Signed-off-by: Markus Armbruster > --- > hw/ide