Re: [Qemu-devel] [PATCH] HMP: Initialize err before using

2018-03-20 Thread Dr. David Alan Gilbert
* Zhangjixiang (jixiang_zh...@h3c.com) wrote: > When bdrv_snapshot_delete return fail, the errp will not be > assigned a valid value in error_propagate as errp didn't be > initialized in hmp_delvm, then error_reportf_err will use an > uninitialized value(call by hmp_delvm), and qemu crash. > > Sig

Re: [Qemu-devel] [PATCH] HMP: Initialize err before using

2018-03-07 Thread Dr. David Alan Gilbert
* Zhangjixiang (jixiang_zh...@h3c.com) wrote: > When bdrv_snapshot_delete return fail, the errp will not be > assigned a valid value in error_propagate as errp didn't be > initialized in hmp_delvm, then error_reportf_err will use an > uninitialized value(call by hmp_delvm), and qemu crash. > > Sig

Re: [Qemu-devel] [PATCH] HMP: Initialize err before using

2018-02-26 Thread Dr. David Alan Gilbert
* Zhangjixiang (jixiang_zh...@h3c.com) wrote: > From 295640e6f4aa83b843e245bb1af9995be37de84d Mon Sep 17 00:00:00 2001 > From: zhangjixiang > Date: Sun, 25 Feb 2018 09:47:51 +0800 > Subject: [PATCH] HMP: Initialize err before using > > When bdrv_snapshot_delete return fail, the errp will not be >