Re: [Qemu-devel] [PATCH] HACK: Centralize sve property checks

2019-09-04 Thread Richard Henderson
On 9/4/19 1:32 AM, Andrew Jones wrote: > How would you suggest > I apply credit for it? I can give you authorship for any patches that > mainly contain your code. Or I can keep authorship and add mentions of > your contributions in the commit messages. Just let me know your > preference. I don't m

Re: [Qemu-devel] [PATCH] HACK: Centralize sve property checks

2019-09-04 Thread Richard Henderson
On 9/4/19 1:32 AM, Andrew Jones wrote: > Should we already introduce a function that will collect all > finalizers together now, rather than sprinkling around > arm_cpu_sve_finalize() calls? Something like > > void arm_cpu_finalize_features(ARMCPU *cpu, Error **errp) > { > arm_cpu_sve_finalize(

Re: [Qemu-devel] [PATCH] HACK: Centralize sve property checks

2019-09-04 Thread Andrew Jones
On Fri, Aug 09, 2019 at 06:31:12PM -0700, Richard Henderson wrote: > As promised, an experiment in unifying the checks. > > I believe that I've tested for all of the same conditions, modulo the > timing at which they are emitted. As before, only one error is reported, > so if multiple errors exis