Re: [Qemu-devel] [PATCH] Add compat eventfd header

2011-06-29 Thread Michael S. Tsirkin
On Wed, Jun 29, 2011 at 05:30:24PM +0200, Alexander Graf wrote: > > On 29.06.2011, at 17:28, Michael S. Tsirkin wrote: > > > On Wed, Jun 29, 2011 at 04:07:50PM +0200, Alexander Graf wrote: > >> > >> On 29.06.2011, at 15:59, Michael S. Tsirkin wrote: > >> > >>> On Wed, Jun 29, 2011 at 03:22:33PM

Re: [Qemu-devel] [PATCH] Add compat eventfd header

2011-06-29 Thread Michael S. Tsirkin
On Wed, Jun 29, 2011 at 04:07:50PM +0200, Alexander Graf wrote: > > On 29.06.2011, at 15:59, Michael S. Tsirkin wrote: > > > On Wed, Jun 29, 2011 at 03:22:33PM +0200, Alexander Graf wrote: > >> > >> On 29.06.2011, at 15:11, Michael S. Tsirkin wrote: > >> > >>> On Wed, Jun 29, 2011 at 03:02:46PM

Re: [Qemu-devel] [PATCH] Add compat eventfd header

2011-06-29 Thread Paolo Bonzini
On 06/29/2011 03:22 PM, Alexander Graf wrote: Well, you need to make sure that it only gets included on Linux systems and if there's ever some more compatibility wrapping around the syscall (unlikely, but you never know), this could potentially break. Also, who defines SYS_eventfd? What if you'r

Re: [Qemu-devel] [PATCH] Add compat eventfd header

2011-06-29 Thread Alexander Graf
On 29.06.2011, at 17:28, Michael S. Tsirkin wrote: > On Wed, Jun 29, 2011 at 04:07:50PM +0200, Alexander Graf wrote: >> >> On 29.06.2011, at 15:59, Michael S. Tsirkin wrote: >> >>> On Wed, Jun 29, 2011 at 03:22:33PM +0200, Alexander Graf wrote: On 29.06.2011, at 15:11, Michael S. Tsi

Re: [Qemu-devel] [PATCH] Add compat eventfd header

2011-06-29 Thread Michael S. Tsirkin
On Wed, Jun 29, 2011 at 03:22:33PM +0200, Alexander Graf wrote: > > On 29.06.2011, at 15:11, Michael S. Tsirkin wrote: > > > On Wed, Jun 29, 2011 at 03:02:46PM +0200, Alexander Graf wrote: > >> > >> On 28.06.2011, at 17:35, Michael S. Tsirkin wrote: > >> > >>> Support build on RHEL 5.X where we

Re: [Qemu-devel] [PATCH] Add compat eventfd header

2011-06-29 Thread Alexander Graf
On 29.06.2011, at 15:59, Michael S. Tsirkin wrote: > On Wed, Jun 29, 2011 at 03:22:33PM +0200, Alexander Graf wrote: >> >> On 29.06.2011, at 15:11, Michael S. Tsirkin wrote: >> >>> On Wed, Jun 29, 2011 at 03:02:46PM +0200, Alexander Graf wrote: On 28.06.2011, at 17:35, Michael S. Tsi

Re: [Qemu-devel] [PATCH] Add compat eventfd header

2011-06-29 Thread Alexander Graf
On 29.06.2011, at 15:11, Michael S. Tsirkin wrote: > On Wed, Jun 29, 2011 at 03:02:46PM +0200, Alexander Graf wrote: >> >> On 28.06.2011, at 17:35, Michael S. Tsirkin wrote: >> >>> Support build on RHEL 5.X where we have syscall for eventfd but not >>> userspace wrapper. >>> >>> (cherry-picked

Re: [Qemu-devel] [PATCH] Add compat eventfd header

2011-06-29 Thread Michael S. Tsirkin
On Wed, Jun 29, 2011 at 03:02:46PM +0200, Alexander Graf wrote: > > On 28.06.2011, at 17:35, Michael S. Tsirkin wrote: > > > Support build on RHEL 5.X where we have syscall for eventfd but not > > userspace wrapper. > > > > (cherry-picked from commit 9e3269181e9bc56feb43bcd4e8ce0b82cd543e65 > >

Re: [Qemu-devel] [PATCH] Add compat eventfd header

2011-06-29 Thread Alexander Graf
On 28.06.2011, at 17:35, Michael S. Tsirkin wrote: > Support build on RHEL 5.X where we have syscall for eventfd but not > userspace wrapper. > > (cherry-picked from commit 9e3269181e9bc56feb43bcd4e8ce0b82cd543e65 > in qemu-kvm.git). > > Signed-off-by: Michael S. Tsirkin > --- > compat/sys/eve