Re: [Qemu-devel] [PATCH] Add TPM support

2007-11-11 Thread Thomas Bleher
* Fabrice Bellard <[EMAIL PROTECTED]> [2007-11-07 18:35]: > A few more remarks : > > - tpm_register() must be called in hw/pc.c. > > - you must also handle incomplete write and reads. Use something like > unix_write() in vl.c and the equivalent for read. > > - The code seems to be Unix specific

Re: [Qemu-devel] [PATCH] Add TPM support

2007-11-07 Thread Fabrice Bellard
A few more remarks : - tpm_register() must be called in hw/pc.c. - you must also handle incomplete write and reads. Use something like unix_write() in vl.c and the equivalent for read. - The code seems to be Unix specific so it must be disabled for win32. Regards, Fabrice.

Re: [Qemu-devel] [PATCH] Add TPM support

2007-11-07 Thread Thomas Bleher
* Fabrice Bellard <[EMAIL PROTECTED]> [2007-11-06 20:47]: > Thomas Bleher wrote: > > * Fabrice Bellard <[EMAIL PROTECTED]> [2007-11-05 16:40]: > >> Thomas Bleher wrote: > > +result = write(s->tpm_fd, s->send_data, s->send_data_index); > > +if (result < s->send_data_index) { > > +

Re: [Qemu-devel] [PATCH] Add TPM support

2007-11-06 Thread Fabrice Bellard
Thomas Bleher wrote: > * Fabrice Bellard <[EMAIL PROTECTED]> [2007-11-05 16:40]: >> Thomas Bleher wrote: >>> Thiemo Seufer told me that GPLv2 is fine for qemu, therefore I'd like to >>> ask that this patch be included in qemu as I posted it (the second >>> version with the clarified GPLv2 license).

Re: [Qemu-devel] [PATCH] Add TPM support

2007-11-06 Thread Thomas Bleher
* Fabrice Bellard <[EMAIL PROTECTED]> [2007-11-05 16:40]: > Thomas Bleher wrote: >> Thiemo Seufer told me that GPLv2 is fine for qemu, therefore I'd like to >> ask that this patch be included in qemu as I posted it (the second >> version with the clarified GPLv2 license). > > I prefer that a BSD st

Re: [Qemu-devel] [PATCH] Add TPM support

2007-11-05 Thread Fabrice Bellard
Thomas Bleher wrote: Thiemo Seufer told me that GPLv2 is fine for qemu, therefore I'd like to ask that this patch be included in qemu as I posted it (the second version with the clarified GPLv2 license). I prefer that a BSD style license is used, especially if the code just contains wrappers.

Re: [Qemu-devel] [PATCH] Add TPM support

2007-11-05 Thread Thomas Bleher
* Thomas Bleher <[EMAIL PROTECTED]> [2007-11-01 16:55]: > * Thiemo Seufer <[EMAIL PROTECTED]> [2007-10-31 17:14]: > > Thomas Bleher wrote: > > > * Thiemo Seufer <[EMAIL PROTECTED]> [2007-10-31 13:54]: > > > > Thomas Bleher wrote: > > > > > --- /dev/null > > > > > +++ b/hw/tpm.c > > > > > @@ -0,0 +1

Re: [Qemu-devel] [PATCH] Add TPM support

2007-11-01 Thread Thomas Bleher
* Thiemo Seufer <[EMAIL PROTECTED]> [2007-10-31 17:14]: > Thomas Bleher wrote: > > * Thiemo Seufer <[EMAIL PROTECTED]> [2007-10-31 13:54]: > > > Thomas Bleher wrote: > > > > --- /dev/null > > > > +++ b/hw/tpm.c > > > > @@ -0,0 +1,219 @@ > > > > +/* > > > > + * TPM emulation > > > > + * Written by T

Re: [Qemu-devel] [PATCH] Add TPM support

2007-10-31 Thread Thiemo Seufer
Thomas Bleher wrote: > This patch adds support for an Atmel TPM chip. > > Background: TPMs are rather complex chips, supporting many commands and > implementing complex crypto protocols like Direct Anonymous Attestation > (DAA). Therefore, this patch does not directly implement a TPM chip, but > i

Re: [Qemu-devel] [PATCH] Add TPM support

2007-10-31 Thread Thomas Bleher
This patch adds support for an Atmel TPM chip. Background: TPMs are rather complex chips, supporting many commands and implementing complex crypto protocols like Direct Anonymous Attestation (DAA). Therefore, this patch does not directly implement a TPM chip, but instead utilizes the TPM emulator

Re: [Qemu-devel] [PATCH] Add TPM support

2007-10-31 Thread Thiemo Seufer
Thomas Bleher wrote: > This patch adds support for an Atmel TPM chip. > > Background: TPMs are rather complex chips, supporting many commands and > implementing complex crypto protocols like Direct Anonymous Attestation > (DAA). Therefore, this patch does not directly implement a TPM chip, but > i